improve UserExistsInGroup

Author: MichalFrends1

Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/AddUserToGroups.cs

@@ -70,44 +70,26 @@ public static Result AddUserToGroups([PropertyTab] Input input, [PropertyTab] Co
 
     private static bool UserExistsInGroup(LdapConnection connection, string userDn, string groupDn, CancellationToken cancellationToken)
     {
-        // Search for the user's groups
+        cancellationToken.ThrowIfCancellationRequested();
+
         ILdapSearchResults searchResults = connection.Search(
             groupDn,
             LdapConnection.ScopeSub,
             "(objectClass=*)",
             null,
             false);
 
-        // Check if the user is a member of the specified group
-        while (searchResults.HasMore())
+        if (searchResults.HasMore())
         {
-            cancellationToken.ThrowIfCancellationRequested();
-            LdapEntry entry;
             try
             {
-                entry = searchResults.Next();
-            }
-            catch (LdapException)
-            {
-                continue;
+                var entry = searchResults.Next();
+                var memberAttr = entry.GetAttribute("member");
+                return memberAttr.StringValueArray.Contains(userDn, StringComparer.OrdinalIgnoreCase);
             }
-
-            if (entry != null)
+            catch (KeyNotFoundException)
             {
-                LdapAttribute memberAttr;
-
-                try
-                {
-                    memberAttr = entry.GetAttribute("member");
-                }
-                catch (KeyNotFoundException)
-                {
-                    continue;
-                }
-
-                var currentMembers = memberAttr.StringValueArray;
-                if (currentMembers.Where(e => e == userDn).Any())
-                    return true;
+                return false;
             }
         }