Skip to content

Commit a670092

Browse files
committed
workflows with timeout
1 parent 5f3d923 commit a670092

File tree

3 files changed

+35
-15
lines changed

3 files changed

+35
-15
lines changed

.github/workflows/SearchObjects_build_and_test_on_main.yml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,23 @@ jobs:
1414
with:
1515
workdir: Frends.LDAP.SearchObjects
1616
prebuild_command: |
17-
docker run -d -i --rm -p 10389:10389 dwimberger/ldap-ad-it
18-
docker run -d -i --rm -p 20389:389 osixia/openldap:1.5.0 \
19-
--env LDAP_ORGANISATION="Test Org" \
20-
--env LDAP_DOMAIN="example.org" \
21-
--env LDAP_ADMIN_PASSWORD="admin"
17+
docker run -d -i --rm --name ldap1 -p 10389:10389 dwimberger/ldap-ad-it
18+
docker run -d -i --rm --name ldap2 -p 20389:389 \
19+
-e LDAP_ORGANISATION="Test Org" \
20+
-e LDAP_DOMAIN="example.org" \
21+
-e LDAP_ADMIN_PASSWORD="admin" \
22+
osixia/openldap:1.5.0
2223
23-
echo "Sleeping to wait for osixia LDAP..."
24-
sleep 20
24+
echo "Waiting for osixia LDAP to be ready..."
25+
for i in {1..30}; do
26+
if docker logs ldap2 2>&1 | grep -q "slapd starting"; then
27+
echo "osixia LDAP is ready."
28+
break
29+
fi
30+
echo "Still waiting for osixia LDAP ($i)..."
31+
sleep 1
32+
done
33+
34+
echo "Prebuild finished."
2535
secrets:
2636
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}

.github/workflows/SearchObjects_build_and_test_on_push.yml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,24 @@ jobs:
1414
with:
1515
workdir: Frends.LDAP.SearchObjects
1616
prebuild_command: |
17-
docker run -d -i --rm -p 10389:10389 dwimberger/ldap-ad-it
18-
docker run -d -i --rm -p 20389:389 osixia/openldap:1.5.0 \
19-
--env LDAP_ORGANISATION="Test Org" \
20-
--env LDAP_DOMAIN="example.org" \
21-
--env LDAP_ADMIN_PASSWORD="admin"
17+
docker run -d -i --rm --name ldap1 -p 10389:10389 dwimberger/ldap-ad-it
18+
docker run -d -i --rm --name ldap2 -p 20389:389 \
19+
-e LDAP_ORGANISATION="Test Org" \
20+
-e LDAP_DOMAIN="example.org" \
21+
-e LDAP_ADMIN_PASSWORD="admin" \
22+
osixia/openldap:1.5.0
2223
23-
echo "Sleeping to wait for osixia LDAP..."
24-
sleep 20
24+
echo "Waiting for osixia LDAP to be ready..."
25+
for i in {1..30}; do
26+
if docker logs ldap2 2>&1 | grep -q "slapd starting"; then
27+
echo "osixia LDAP is ready."
28+
break
29+
fi
30+
echo "Still waiting for osixia LDAP ($i)..."
31+
sleep 1
32+
done
33+
34+
echo "Prebuild finished."
2535
secrets:
2636
badge_service_api_key: ${{ secrets.BADGE_SERVICE_API_KEY }}
2737
test_feed_api_key: ${{ secrets.TASKS_TEST_FEED_API_KEY }}

Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects.Tests/UnitTestAnonymousBind .cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace Frends.LDAP.SearchObjects.Tests;
1212
public class UnitTestAnonymousBind
1313
{
1414
/*
15-
Create a simple LDAP server to docker for anonymous bind testing.
15+
Create a simple LDAP server to docker for anonymous bind testing
1616
docker run --rm -p 20389:389 -e LDAP_ORGANISATION="Test Org" -e LDAP_DOMAIN="example.org" -e LDAP_ADMIN_PASSWORD="admin" osixia/openldap:1.5.0
1717
*/
1818

0 commit comments

Comments
 (0)