Merge pull request #44 from FrendsPlatform/FSPES-64

MatteoDelOmbra · web-flow · commit e7b78dabcb33 · 2026-02-03T12:29:32.000+01:00
update summary for host param
diff --git a/Frends.LDAP.AddUserToGroups/CHANGELOG.md b/Frends.LDAP.AddUserToGroups/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [2.1.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [2.0.0] - 2026-01-29
 ### Changed
 - [Breaking] Input: Changed GroupDistinguishedName (string) to GroupDistinguishedNames (string[]) to support adding users to multiple groups in a single operation.
diff --git a/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/Definitions/Connection.cs b/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/Definitions/Connection.cs
@@ -7,9 +7,11 @@ namespace Frends.LDAP.AddUserToGroups.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This must resolve to a Domain Controller (FQDN) in the same domain
+    /// as the target group being modified.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>dc1.emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups.csproj b/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups/Frends.LDAP.AddUserToGroups.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>2.0.0</Version>
+	<Version>2.1.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>
diff --git a/Frends.LDAP.CreateUser/CHANGELOG.md b/Frends.LDAP.CreateUser/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.2.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [1.1.0] - 2025-09-26
 ### Updated
 - Added option to set the password for the new user in Unicode.
diff --git a/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser/Definitions/Connection.cs b/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser/Definitions/Connection.cs
@@ -7,9 +7,11 @@ namespace Frends.LDAP.CreateUser.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This must resolve to a Domain Controller (FQDN) in the same domain
+    /// where the new object (user) will be created.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>dc1.emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser.csproj b/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser/Frends.LDAP.CreateUser.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFrameworks>net6.0</TargetFrameworks>
-		<Version>1.1.0</Version>
+		<Version>1.2.0</Version>
 		<Authors>Frends</Authors>
 		<Copyright>Frends</Copyright>
 		<Company>Frends</Company>
diff --git a/Frends.LDAP.DeleteUser/CHANGELOG.md b/Frends.LDAP.DeleteUser/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.1.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [1.0.0] - 2022-09-26
 ### Added
 - Initial implementation
diff --git a/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/Definitions/Connection.cs b/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/Definitions/Connection.cs
@@ -7,9 +7,11 @@ namespace Frends.LDAP.DeleteUser.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This must resolve to a Domain Controller (FQDN) in the same domain
+    /// as the object (user) being deleted.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>dc1.emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/DeleteUser.cs b/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/DeleteUser.cs
@@ -27,7 +27,7 @@ public static Result DeleteUser([PropertyTab] Input input, [PropertyTab] Connect
         {
             var defaultPort = connection.SecureSocketLayer ? 636 : 389;
             var entry = $"CN={input.CommonName},{input.Path}";
-            
+
             conn.SecureSocketLayer = connection.SecureSocketLayer;
             conn.Connect(connection.Host, connection.Port == 0 ? defaultPort : connection.Port);
             if (connection.TLS) conn.StartTls();
diff --git a/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser.csproj b/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser/Frends.LDAP.DeleteUser.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>1.0.0</Version>
+	<Version>1.1.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>
diff --git a/Frends.LDAP.RemoveUserFromGroups/CHANGELOG.md b/Frends.LDAP.RemoveUserFromGroups/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.1.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [1.0.0] - 2022-10-13
 ### Added
 - Initial implementation
diff --git a/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Definitions/Connection.cs b/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Definitions/Connection.cs
@@ -7,9 +7,11 @@ namespace Frends.LDAP.RemoveUserFromGroups.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This must resolve to a Domain Controller (FQDN) in the same domain
+    /// as the target group being modified.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>dc1.emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Definitions/Input.cs b/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Definitions/Input.cs
@@ -24,5 +24,5 @@ public class Input
     /// </summary>
     /// <example>HandleLDAPError.Throw</example>
     [DefaultValue(HandleLDAPError.Throw)]
-    public HandleLDAPError HandleLDAPError { get; set; } 
+    public HandleLDAPError HandleLDAPError { get; set; }
 }
diff --git a/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups.csproj b/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>1.0.0</Version>
+	<Version>1.1.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>
diff --git a/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/RemoveUserFromGroups.cs b/Frends.LDAP.RemoveUserFromGroups/Frends.LDAP.RemoveUserFromGroups/RemoveUserFromGroups.cs
@@ -33,16 +33,16 @@ public static Result RemoveUserFromGroups([PropertyTab] Input input, [PropertyTa
             if (connection.TLS) conn.StartTls();
             conn.Bind(connection.User, connection.Password);
 
-			LdapModification[] mods = new LdapModification[1];
-			var member = new LdapAttribute("member", input.UserDistinguishedName);
-			mods[0] = new LdapModification(LdapModification.Delete, member);
-			conn.Modify(input.GroupDistinguishedName, mods);
+            LdapModification[] mods = new LdapModification[1];
+            var member = new LdapAttribute("member", input.UserDistinguishedName);
+            mods[0] = new LdapModification(LdapModification.Delete, member);
+            conn.Modify(input.GroupDistinguishedName, mods);
 
-			return new Result(true, null, input.UserDistinguishedName, input.GroupDistinguishedName);
+            return new Result(true, null, input.UserDistinguishedName, input.GroupDistinguishedName);
         }
         catch (LdapException ex)
         {
-            if (input.HandleLDAPError.Equals(HandleLDAPError.Skip)) 
+            if (input.HandleLDAPError.Equals(HandleLDAPError.Skip))
                 return new Result(false, ex.Message, input.UserDistinguishedName, input.GroupDistinguishedName);
             else
                 throw new Exception($"RemoveUserFromGroups LDAP error: {ex.Message}");
diff --git a/Frends.LDAP.SearchObjects/CHANGELOG.md b/Frends.LDAP.SearchObjects/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [4.2.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [4.1.0] - 2025-06-17
 ### Added
 - Improved LDAP error handling by validating bind status and checking search response codes.
diff --git a/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Definitions/Connection.cs b/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Definitions/Connection.cs
@@ -8,9 +8,10 @@ namespace Frends.LDAP.SearchObjects.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This can be a domain name, LDAP alias, or a Domain Controller FQDN.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects.csproj b/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>4.1.0</Version>
+	<Version>4.2.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>
diff --git a/Frends.LDAP.UpdateUser/CHANGELOG.md b/Frends.LDAP.UpdateUser/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.2.0] - 2026-02-03
+### Changed
+- Improved documentation for Host parameter usage
+
 ## [1.1.0] - 2022-12-14
 ### Added
 - New Input parameters CreateDN and DistinguishedName to give an option to insert DN without combining it from Input.CommonName and Input.Path.
diff --git a/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/Definitions/Connection.cs b/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/Definitions/Connection.cs
@@ -7,9 +7,11 @@ namespace Frends.LDAP.UpdateUser.Definitions;
 public class Connection
 {
     /// <summary>
-    /// Host.
+    /// LDAP server host.
+    /// This must resolve to a Domain Controller (FQDN) in the same domain
+    /// as the user being updated.
     /// </summary>
-    /// <example>adserver.westeurope.cloudapp.azure.com</example>
+    /// <example>dc1.emea.company.com</example>
     public string Host { get; set; }
 
     /// <summary>
diff --git a/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser.csproj b/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
 	<TargetFrameworks>net6.0</TargetFrameworks>
-	<Version>1.1.0</Version>
+	<Version>1.2.0</Version>
 	<Authors>Frends</Authors>
 	<Copyright>Frends</Copyright>
 	<Company>Frends</Company>
diff --git a/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/UpdateUser.cs b/Frends.LDAP.UpdateUser/Frends.LDAP.UpdateUser/UpdateUser.cs
@@ -66,7 +66,7 @@ public static Result UpdateUser([PropertyTab] Input input, [PropertyTab] Connect
 
             foreach (var item in input.Attributes)
                 modList.Add(new LdapModification(modMethod, new LdapAttribute(item.Key, string.IsNullOrWhiteSpace(item.Value) ? " " : item.Value)));
-            
+
             var mods = new LdapModification[modList.Count];
             var mtype = Type.GetType("Novell.Directory.LdapModification");
             mods = (LdapModification[])modList.ToArray(typeof(LdapModification));

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public static Result DeleteUser([PropertyTab] Input input, [PropertyTab] Connect`
`27`	`27`	`{`
`28`	`28`	`var defaultPort = connection.SecureSocketLayer ? 636 : 389;`
`29`	`29`	`var entry = $"CN={input.CommonName},{input.Path}";`
`30`		`-`
	`30`	`+`
`31`	`31`	`conn.SecureSocketLayer = connection.SecureSocketLayer;`
`32`	`32`	`conn.Connect(connection.Host, connection.Port == 0 ? defaultPort : connection.Port);`
`33`	`33`	`if (connection.TLS) conn.StartTls();`