[2.x] chore: increase phpstan to level 6 (#61)

* chore: increase phpstan to level 6

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

Author: imorland

phpstan.neon

@@ -2,8 +2,7 @@ includes:
   - vendor/flarum/phpstan/extension.neon
 
 parameters:
-  # The level will be increased in Flarum 2.0
-  level: 5
+  level: 6
   paths:
     - extend.php
     - src

src/Access/ScopePageVisibility.php

@@ -16,7 +16,7 @@
 
 class ScopePageVisibility
 {
-    public function __invoke(User $actor, Builder $query)
+    public function __invoke(User $actor, Builder $query): void
     {
         if (!$actor->hasPermission('fof-pages.viewHidden')) {
             $query->where('is_hidden', false);

src/Api/Resource/PageResource.php

@@ -48,11 +48,17 @@ public function model(): string
         return Page::class;
     }
 
+    /**
+     * @param FlarumContext $context
+     */
     public function scope(Builder $query, Context $context): void
     {
         $query->whereVisibleTo($context->getActor());
     }
 
+    /**
+     * @param FlarumContext $context
+     */
     public function find(string $id, Context $context): ?object
     {
         return $this->pages->findOrFail((int) $id, $context->getActor());
@@ -127,8 +133,11 @@ public function sorts(): array
         ];
     }
 
-    /** @param Page $model */
-    public function created($model, Context $context): ?object
+    /**
+     * @param Page          $model
+     * @param FlarumContext $context
+     */
+    public function created(object $model, Context $context): ?object
     {
         $this->events->dispatch(
             new PageCreated($model, $context->getActor())
@@ -137,6 +146,10 @@ public function created($model, Context $context): ?object
         return parent::created($model, $context);
     }
 
+    /**
+     * @param Page          $model
+     * @param FlarumContext $context
+     */
     public function deleted(object $model, Context $context): void
     {
         $this->events->dispatch(

src/Command/DeletePage.php

@@ -16,7 +16,7 @@
 class DeletePage
 {
     public function __construct(
-        public $pageId,
+        public int|string $pageId,
         public User $actor,
         public array $data = []
     ) {

src/Content/AddHomePageId.php

@@ -21,7 +21,7 @@ public function __construct(
     ) {
     }
 
-    public function __invoke(Document $document)
+    public function __invoke(Document $document): void
     {
         if (($id = $this->settings->get('pages_home')) !== null) {
             $document->payload['fof-pages.home'] = $id;

src/Content/Page.php

@@ -30,7 +30,7 @@ public function __construct(
     ) {
     }
 
-    public function __invoke(Document $document, ServerRequestInterface $request)
+    public function __invoke(Document $document, ServerRequestInterface $request): void
     {
         $queryParams = $request->getQueryParams();
 
@@ -45,7 +45,7 @@ public function __invoke(Document $document, ServerRequestInterface $request)
         $document->payload['apiDocument'] = $apiDocument;
     }
 
-    private function getApiDocument(ServerRequestInterface $request, $id)
+    private function getApiDocument(ServerRequestInterface $request, int|string|null $id): object
     {
         $response = $this->api->withParentRequest($request)->get('/pages/'.$id);
 

src/Page.php

@@ -80,7 +80,7 @@ public function getParsedContentAttribute()
      *
      * @param string $value
      */
-    public function setContentAttribute($value)
+    public function setContentAttribute($value): void
     {
         $this->attributes['content'] = $value ? static::$formatter->parse($value, $this) : null;
     }
@@ -114,7 +114,7 @@ public static function getFormatter()
      *
      * @param \Flarum\Formatter\Formatter $formatter
      */
-    public static function setFormatter(Formatter $formatter)
+    public static function setFormatter(Formatter $formatter): void
     {
         static::$formatter = $formatter;
     }

src/Providers/PageServiceProvider.php

@@ -19,7 +19,7 @@
 
 class PageServiceProvider extends AbstractServiceProvider
 {
-    public function boot()
+    public function boot(): void
     {
         $this->container->instance('path.pages', $this->container->make(Paths::class)->base.DIRECTORY_SEPARATOR.'pages');