Merge pull request #219 from mlocati/require-zip-only-when-needed

Check for zip/unzip capability only when needed

Author: mlocati

src/Console/Application.php

@@ -38,7 +38,6 @@
 
 use Exception;
 use Phar;
-use Pickle\Base\Archive;
 use Symfony\Component\Console\Application as BaseApplication;
 
 class Application extends BaseApplication
@@ -97,8 +96,5 @@ private static function checkExtensions()
                 throw new Exception("Extension '{$ext}' required but not loaded, full required list: " . implode(', ', $required_exts));
             }
         }
-
-        Archive\Factory::getUnzipperClassName();
-        Archive\Factory::getZipperClassName();
     }
 }

src/Console/Command/InstallerCommand.php

@@ -38,6 +38,7 @@
 
 use Exception;
 use Pickle\Base\Abstracts\Console\Command\BuildCommand;
+use Pickle\Base\Archive\Factory;
 use Pickle\Base\Util;
 use Pickle\Engine;
 use Pickle\Package\Command\Install;
@@ -119,6 +120,7 @@ protected function configure()
      */
     protected function binaryInstallWindows($path, InputInterface $input, OutputInterface $output)
     {
+        Factory::getUnzipperClassName(); // Be sure we have a way to unzip files
         $php = Engine::factory();
         $table = new Table($output);
         $table

src/Console/Command/ReleaseCommand.php

@@ -38,6 +38,7 @@
 
 use Exception;
 use Pickle\Base\Abstracts\Console\Command\BuildCommand;
+use Pickle\Base\Archive\Factory;
 use Pickle\Base\Interfaces;
 use Pickle\Base\Util;
 use Pickle\Package\Command\Release;
@@ -87,6 +88,9 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        if (DIRECTORY_SEPARATOR === '\\' || $input->getOption('pack-logs')) {
+            Factory::getZipperClassName(); // Be sure we have a way to zip files
+        }
         $helper = $this->getHelper('package');
         Util\TmpDir::set($input->getOption('tmp-dir'));