Skip to content

Commit 147511f

Browse files
committed
Allow passing options without being a real file
By removing the `is_file` check we allow installing extensions like this: ```bash bin/pickle install --source --with-configure-options <(echo --with-rdkafka=/opt/homebrew/opt/librdkafka) rdkafka ``` No more need to create a file with the options first.
1 parent eb4c247 commit 147511f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Base/Abstracts/Console/Command/BuildCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ protected function buildOptions(Package $package, InputInterface $input, OutputI
101101
$force_opts = $input->getOption('with-configure-options');
102102

103103
if ($force_opts) {
104-
if (!file_exists($force_opts) || !is_file($force_opts) || !is_readable($force_opts)) {
104+
if (!file_exists($force_opts) || !is_readable($force_opts)) {
105105
throw new Exception("File '{$force_opts}' is unusable");
106106
}
107107

0 commit comments

Comments
 (0)