Merge pull request #657 from Ocramius/dependabot/composer/vimeo/psalm-4.3.2

Bump vimeo/psalm from 3.12.2 to 4.3.2

Author: Ocramius

composer.json

@@ -38,7 +38,7 @@
         "nikic/php-parser":             "^4.6.0",
         "phpbench/phpbench":            "^0.17.1",
         "infection/infection":          "^0.16.4",
-        "vimeo/psalm":                  "^3.12.2",
+        "vimeo/psalm":                  "^4.3.2",
         "codelicia/xulieta":            "^0.1.2"
     },
     "suggest": {

composer.lock

@@ -40,7 +40,6 @@
 
         <DeprecatedMethod>
             <errorLevel type="suppress">
-                <referencedMethod name="ProxyManager\ProxyGenerator\Util\Properties::onlyPropertiesThatCanBeUnset"/>
                 <directory name="tests" />
             </errorLevel>
         </DeprecatedMethod>

psalm.xml

@@ -124,7 +124,6 @@ public function onlyNullableProperties(): self
             $this->properties,
             static function (ReflectionProperty $property): bool {
                 $type = $property->getType();
-                assert($type instanceof ReflectionType || $type === null);
 
                 return $type === null || $type->allowsNull();
             }

src/ProxyManager/ProxyGenerator/Util/Properties.php

@@ -48,6 +48,7 @@ public function setUp(): void
 
     public function benchOriginalConstructorInstantiationOfEmptyObject(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->emptyClassProxy();
     }
 
@@ -60,6 +61,7 @@ public function benchInstantiationOfEmptyObject(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithPrivateProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->privatePropertiesProxy();
     }
 
@@ -72,6 +74,7 @@ public function benchInstantiationOfObjectWithPrivateProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithProtectedProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->protectedPropertiesProxy();
     }
 
@@ -84,6 +87,7 @@ public function benchInstantiationOfObjectWithProtectedProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithPublicProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->publicPropertiesProxy();
     }
 
@@ -96,6 +100,7 @@ public function benchInstantiationOfObjectWithPublicProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithMixedProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->mixedPropertiesProxy();
     }
 

tests/ProxyManagerBench/LazyLoadingGhostInstantiationBench.php

@@ -52,6 +52,7 @@ public function setUp(): void
 
     public function benchOriginalConstructorInstantiationOfEmptyObject(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->emptyClassProxy();
     }
 
@@ -64,6 +65,7 @@ public function benchInstantiationOfEmptyObject(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithPrivateProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->privatePropertiesProxy();
     }
 
@@ -76,6 +78,7 @@ public function benchInstantiationOfObjectWithPrivateProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithProtectedProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->protectedPropertiesProxy();
     }
 
@@ -88,6 +91,7 @@ public function benchInstantiationOfObjectWithProtectedProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithPublicProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->publicPropertiesProxy();
     }
 
@@ -100,6 +104,7 @@ public function benchInstantiationOfObjectWithPublicProperties(): void
 
     public function benchOriginalConstructorInstantiationOfObjectWithMixedProperties(): void
     {
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         new $this->mixedPropertiesProxy();
     }
 

tests/ProxyManagerBench/LazyLoadingValueHolderInstantiationBench.php

@@ -224,6 +224,7 @@ static function (
             ) use ($originalClass): bool {
                 $initializer = null;
 
+                /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
                 $valueHolder = new $originalClass();
 
                 return true;

tests/ProxyManagerBench/LazyLoadingValueHolderPropertyAccessBench.php

@@ -31,7 +31,7 @@ final class AbstractBaseFactoryTest extends TestCase
     /**
      * Note: we mock the class in order to assert on the abstract method usage
      *
-     * @var AbstractBaseFactory|MockObject
+     * @var AbstractBaseFactory&MockObject
      */
     private AbstractBaseFactory $factory;
 

tests/ProxyManagerTest/Factory/AbstractBaseFactoryTest.php

@@ -345,6 +345,7 @@ public function testWillBehaveLikeObjectWithNormalConstructor(): void
                 ->createProxy(new ClassWithCounterConstructor(0))
         );
 
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         $proxy = new $proxyName(15);
 
         self::assertSame(15, $proxy->amount, 'Verifying that the proxy constructor works as expected');

tests/ProxyManagerTest/Functional/AccessInterceptorScopeLocalizerFunctionalTest.php

@@ -350,6 +350,7 @@ public function testWillBehaveLikeObjectWithNormalConstructor(): void
                 ->createProxy(new ClassWithCounterConstructor(0))
         );
 
+        /** @psalm-suppress UnsafeInstantiation it is allowed (by design) to instantiate these proxies */
         $proxy = new $proxyName(15);
 
         self::assertSame(15, $proxy->amount, 'Verifying that the proxy constructor works as expected');