Skip to content

Commit 9bad027

Browse files
committed
#657 prevent installation of older thecodingmachine/safe versions with ocramius/proxy-manager
Sadly, `thecodingmachine/safe` has too lax dependency ranges ( https://github.com/thecodingmachine/safe/blob/a8ab0876305a4cdaef31b2350fcb9811b5608dbc/composer.json#L106 ), and this trips testing for lower dependency ranges in CI. As previously highlighted multiple times on the internets, `>=` and `*` (unbounded) should be avoided when dealing with dependency ranges, as major releases **will** break, and old dependencies will be installed by accident.
1 parent 38014a0 commit 9bad027

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
"conflict": {
2828
"zendframework/zend-stdlib": "<3.2.1",
2929
"laminas/laminas-stdlib": "<3.2.1",
30-
"doctrine/annotations": "<1.6.1"
30+
"doctrine/annotations": "<1.6.1",
31+
"thecodingmachine/safe": "<1.3.3"
3132
},
3233
"require-dev": {
3334
"ext-phar": "*",

composer.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)