chore: make code more stable

tinect · tinect · commit 9f2eaf7453b3 · 2025-06-17T21:54:22.000+02:00
diff --git a/src/Controller/Api/TestController.php b/src/Controller/Api/TestController.php
@@ -83,7 +83,7 @@ private function getProductFolderId(Context $context): string
             ->searchIds($criteria, $context)
             ->getIds();
 
-        if (!empty($ids[0]) && \is_string($ids[0])) {
+        if (isset($ids[0]) && \is_string($ids[0])) {
             return $ids[0];
         }
 
@@ -100,7 +100,7 @@ private function getSampleMedia(string $testFile): MediaEntity
         $pathInfo = pathinfo($testFile);
 
         $existingMedia = $this->getMediaById($pathInfo['filename'], $context);
-        if ($existingMedia) {
+        if ($existingMedia !== null) {
             return $existingMedia;
         }
 
@@ -130,7 +130,7 @@ private function getSampleMedia(string $testFile): MediaEntity
         );
 
         $existingMedia = $this->getMediaById($pathInfo['filename'], $context);
-        if ($existingMedia) {
+        if ($existingMedia !== null) {
             return $existingMedia;
         }
 
diff --git a/src/Core/Media/MediaUrlGenerator.php b/src/Core/Media/MediaUrlGenerator.php
@@ -62,7 +62,6 @@ public function generate(array $paths): array
     private function canProcess(string $path): bool
     {
         $fileExtension = \pathinfo($path, \PATHINFO_EXTENSION);
-        \assert(\is_string($fileExtension));
 
         return $this->canProcessFileExtension($fileExtension);
     }
@@ -71,7 +70,7 @@ private function canProcessFileExtension(string $fileExtension): bool
     {
         $extensionsAllowList = $this->getExtensionsAllowList();
 
-        if (empty($extensionsAllowList)) {
+        if ($extensionsAllowList === []) {
             return false;
         }
 
@@ -101,7 +100,8 @@ private function getExtensionsAllowList(): array
                     \explode(
                         ',',
                         (string) \preg_replace('/\s+/', '', \strtolower($extensionsAllowListConfig))
-                    )
+                    ),
+                    static fn($value) => $value !== ''
                 )
             );
         }
@@ -111,7 +111,7 @@ private function getExtensionsAllowList(): array
 
     private function getWidth(string $maxWidth, UrlParams $value): string
     {
-        if ($value instanceof ExtendedUrlParams && !empty($value->width)) {
+        if ($value instanceof ExtendedUrlParams && $value->width !== null && $value->width !== 0) {
             return (string) $value->width;
         }
 
diff --git a/src/Core/Media/MediaUrlLoader.php b/src/Core/Media/MediaUrlLoader.php
@@ -18,7 +18,7 @@ public function loaded(iterable $entities): void
     {
         $mapping = $this->map($entities);
 
-        if (empty($mapping)) {
+        if ($mapping !== []) {
             return;
         }
 
@@ -65,12 +65,12 @@ private function map(iterable $entities): array
         $mapped = [];
 
         foreach ($entities as $entity) {
-            if (!$entity->has('path') || empty($entity->get('path'))) {
+            if (!$entity->has('path') || $entity->get('path') === null || $entity->get('path') === '') {
                 continue;
             }
 
             // don't generate private urls
-            if (!$entity->has('private') || $entity->get('private')) {
+            if (!$entity->has('private') || $entity->get('private') === true) {
                 continue;
             }
 
@@ -91,7 +91,7 @@ private function map(iterable $entities): array
                     continue;
                 }
 
-                if (!$thumbnail->has('path') || empty($thumbnail->get('path'))) {
+                if (!$thumbnail->has('path') || $thumbnail->get('path') === null || $thumbnail->get('path') === '') {
                     continue;
                 }
 
diff --git a/src/DependencyInjection/GeneratorCompilerPass.php b/src/DependencyInjection/GeneratorCompilerPass.php
@@ -34,7 +34,7 @@ public function process(ContainerBuilder $container): void
     {
         $fileContents = $this->getFileContent();
 
-        if (empty($fileContents)) {
+        if ($fileContents === null || $fileContents === '') {
             $this->removeReflectionClass();
 
             return;
@@ -71,7 +71,7 @@ public function process(ContainerBuilder $container): void
         $doc = '/**' . \PHP_EOL . 'THIS CLASS HAS BEEN GENERATED AUTOMATICALLY' . \PHP_EOL . '*/';
 
         $existingDocs = $class->getDocComment()?->getText() ?? '';
-        if (!empty($existingDocs)) {
+        if ($existingDocs !== '') {
             $doc .= \PHP_EOL . $existingDocs;
         }
 
@@ -123,7 +123,7 @@ private function handleThumbnailService(NodeFinder $nodeFinder, array $ast): voi
         $updateThumbnailsNode = $this->getClassMethod($nodeFinder, 'updateThumbnails', $ast);
 
         $stmts = $updateThumbnailsNode->getStmts();
-        if (empty($stmts)) {
+        if ($stmts === null || $stmts === []) {
             throw new \RuntimeException(\sprintf('Method %s in class %s is empty', 'updateThumbnails', $this->class));
         }
 
@@ -174,7 +174,7 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void
         $filePath = $this->getFileName();
         $files = glob(\dirname($filePath) . '/*.php');
 
-        if (empty($files)) {
+        if ($files === false || $files === []) {
             return;
         }
 
@@ -188,7 +188,7 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void
             $uses[] = new UseUse(new Name($class));
         }
 
-        if (empty($uses)) {
+        if ($uses === []) {
             return;
         }
 
@@ -197,7 +197,13 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void
 
     private function getFileContent(): ?string
     {
-        return file_get_contents($this->getFileName()) ?: null;
+        $content = file_get_contents($this->getFileName());
+
+        if (\is_string($content)) {
+            return $content;
+        }
+
+        return null;
     }
 
     private function getFileName(): string
@@ -206,7 +212,7 @@ private function getFileName(): string
 
         $fileName = $reflectionClass->getFileName();
 
-        if (empty($fileName)) {
+        if ($fileName === false || $fileName === '') {
             throw new \RuntimeException(\sprintf('Cannot get fileName of class %s', $this->class));
         }
 
@@ -231,7 +237,7 @@ private function getClassName(): string
     {
         $lastOccur = strrchr($this->class, '\\');
 
-        if (empty($lastOccur)) {
+        if ($lastOccur === false || $lastOccur === '') {
             throw new \RuntimeException(\sprintf('Cannot determine className from %s', $this->class));
         }
 
diff --git a/src/EventListener/ThumbnailSizesChangedListener.php b/src/EventListener/ThumbnailSizesChangedListener.php
@@ -36,14 +36,14 @@ public function onThumbnailSizeChanged(EntityWrittenEvent $event): void
         foreach ($event->getWriteResults() as $writeResult) {
             $mediaFolderConfigurationId = $writeResult->getPayload()['mediaFolderConfigurationId'] ?? null;
 
-            if (!empty($mediaFolderConfigurationId) && \is_string($mediaFolderConfigurationId)) {
+            if ($mediaFolderConfigurationId !== '' && \is_string($mediaFolderConfigurationId)) {
                 $updatedMediaFolderConfigurationIds[] = $mediaFolderConfigurationId;
             }
         }
 
         $updatedMediaFolderConfigurationIds = \array_unique($updatedMediaFolderConfigurationIds);
 
-        if (empty($updatedMediaFolderConfigurationIds)) {
+        if ($updatedMediaFolderConfigurationIds === []) {
             return;
         }
 
diff --git a/src/Migration/Migration1686772873AddActiveConfig.php b/src/Migration/Migration1686772873AddActiveConfig.php
@@ -16,7 +16,7 @@ public function update(Connection $connection): void
     {
         $currentPluginVersion = $this->getPluginVersion($connection);
 
-        if (empty($currentPluginVersion)) {
+        if ($currentPluginVersion === null || $currentPluginVersion === '') {
             return;
         }
 
diff --git a/src/Service/ConfigReader.php b/src/Service/ConfigReader.php
@@ -66,7 +66,7 @@ private function isActive(mixed $config): bool
             return true;
         }
 
-        return $this->isTestActive() || !empty($config);
+        return $this->isTestActive() || ($config !== false && $config !== '0' && $config !== 0);
     }
 
     private function isTestActive(): bool
diff --git a/src/Service/ThumbnailUrlTemplate.php b/src/Service/ThumbnailUrlTemplate.php
@@ -13,9 +13,11 @@ public function __construct(
 
     public function getUrl(string $mediaUrl, string $mediaPath, string $width, ?\DateTimeInterface $mediaUpdatedAt): string
     {
+        $timestamp = $mediaUpdatedAt !== null ? $mediaUpdatedAt->getTimestamp() : '0';
+
         return str_replace(
             ['{mediaUrl}', '{mediaPath}', '{width}', '{mediaUpdatedAt}'],
-            [$mediaUrl, $mediaPath, $width, $mediaUpdatedAt?->getTimestamp() ?: '0'],
+            [$mediaUrl, $mediaPath, $width, $timestamp],
             $this->getPattern()
         );
     }
diff --git a/tests/unit/Core/Media/MediaUrlGeneratorTest.php b/tests/unit/Core/Media/MediaUrlGeneratorTest.php
@@ -21,11 +21,11 @@ public function testGenerateWithUrlParam(): void
     {
         $decoratedMediaUrlGenerator = $this->createMock(AbstractMediaUrlGenerator::class);
         $thumbnailUrlTemplate = $this->createMock(ThumbnailUrlTemplateInterface::class);
-        $thumbnailUrlTemplate->expects(static::once())
+        $thumbnailUrlTemplate->expects($this->once())
             ->method('getUrl')
             ->willReturn('https://localhost/media/123.jpg?width=3000');
         $filesystem = $this->createMock(PrefixFilesystem::class);
-        $filesystem->expects(static::once())
+        $filesystem->expects($this->once())
             ->method('publicUrl')
             ->willReturn('https://localhost');
 
@@ -37,7 +37,7 @@ public function testGenerateWithUrlParam(): void
             'ExtensionsAllowList' => 'jpg',
             'ThumbnailPattern' => '{mediaUrl}/{mediaPath}?width={width}',
         ];
-        $configReader->expects(static::any())
+        $configReader->expects($this->any())
             ->method('getConfig')
             ->willReturnCallback(function ($key) use ($defaultPluginConfig) {
                 return $defaultPluginConfig[$key] ?? null;
@@ -68,11 +68,11 @@ public function testGenerateWithExtendedUrlParam(): void
     {
         $decoratedMediaUrlGenerator = $this->createMock(AbstractMediaUrlGenerator::class);
         $thumbnailUrlTemplate = $this->createMock(ThumbnailUrlTemplateInterface::class);
-        $thumbnailUrlTemplate->expects(static::once())
+        $thumbnailUrlTemplate->expects($this->once())
             ->method('getUrl')
             ->willReturn('https://localhost/media/123.jpg?width=100');
         $filesystem = $this->createMock(PrefixFilesystem::class);
-        $filesystem->expects(static::once())
+        $filesystem->expects($this->once())
             ->method('publicUrl')
             ->willReturn('https://localhost');
 
@@ -84,7 +84,7 @@ public function testGenerateWithExtendedUrlParam(): void
             'ExtensionsAllowList' => 'jpg',
             'ThumbnailPattern' => '{mediaUrl}/{mediaPath}?width={width}',
         ];
-        $configReader->expects(static::any())
+        $configReader->expects($this->any())
             ->method('getConfig')
             ->willReturnCallback(function ($key) use ($defaultPluginConfig) {
                 return $defaultPluginConfig[$key] ?? null;
@@ -120,16 +120,16 @@ public function testGenerateWithExtendedUrlParam(): void
     public function testGenerateWithInactiveConfig(): void
     {
         $decoratedMediaUrlGenerator = $this->createMock(AbstractMediaUrlGenerator::class);
-        $decoratedMediaUrlGenerator->expects(static::once())
+        $decoratedMediaUrlGenerator->expects($this->once())
             ->method('generate')
             ->willReturn(['https://localhost/media/123.jpg']);
 
         $thumbnailUrlTemplate = $this->createMock(ThumbnailUrlTemplateInterface::class);
-        $thumbnailUrlTemplate->expects(static::never())
+        $thumbnailUrlTemplate->expects($this->never())
             ->method('getUrl')
             ->willReturn('https://localhost/media/123.jpg?width=3000');
         $filesystem = $this->createMock(PrefixFilesystem::class);
-        $filesystem->expects(static::never())
+        $filesystem->expects($this->never())
             ->method('publicUrl')
             ->willReturn('https://localhost');
 
@@ -141,7 +141,7 @@ public function testGenerateWithInactiveConfig(): void
             'ExtensionsAllowList' => 'jpg',
             'ThumbnailPattern' => '{mediaUrl}/{mediaPath}?width={width}',
         ];
-        $configReader->expects(static::any())
+        $configReader->expects($this->any())
             ->method('getConfig')
             ->willReturnCallback(function ($key) use ($defaultPluginConfig) {
                 return $defaultPluginConfig[$key] ?? null;
@@ -174,16 +174,16 @@ public function testGenerateWithInactiveConfig(): void
     public function testGenerateWithNotAllowedExtensionResultsInOriginal(string $allowList): void
     {
         $decoratedMediaUrlGenerator = $this->createMock(AbstractMediaUrlGenerator::class);
-        $decoratedMediaUrlGenerator->expects(static::once())
+        $decoratedMediaUrlGenerator->expects($this->once())
             ->method('generate')
             ->willReturn(['https://localhost/media/123.jpg']);
 
         $thumbnailUrlTemplate = $this->createMock(ThumbnailUrlTemplateInterface::class);
-        $thumbnailUrlTemplate->expects(static::never())
+        $thumbnailUrlTemplate->expects($this->never())
             ->method('getUrl')
             ->willReturn('https://localhost/media/123.jpg?width=3000');
         $filesystem = $this->createMock(PrefixFilesystem::class);
-        $filesystem->expects(static::once())
+        $filesystem->expects($this->once())
             ->method('publicUrl')
             ->willReturn('https://localhost');
 
@@ -195,7 +195,7 @@ public function testGenerateWithNotAllowedExtensionResultsInOriginal(string $all
             'ExtensionsAllowList' => $allowList,
             'ThumbnailPattern' => '{mediaUrl}/{mediaPath}?width={width}',
         ];
-        $configReader->expects(static::any())
+        $configReader->expects($this->any())
             ->method('getConfig')
             ->willReturnCallback(function ($key) use ($defaultPluginConfig) {
                 return $defaultPluginConfig[$key] ?? null;
@@ -226,11 +226,11 @@ public function testMultipleGenerationsUseCachedExtensionAllowList(): void
     {
         $decoratedMediaUrlGenerator = $this->createMock(AbstractMediaUrlGenerator::class);
         $thumbnailUrlTemplate = $this->createMock(ThumbnailUrlTemplateInterface::class);
-        $thumbnailUrlTemplate->expects(static::exactly(2))
+        $thumbnailUrlTemplate->expects($this->exactly(2))
             ->method('getUrl')
             ->willReturn('https://localhost/media/123.jpg?width=100');
         $filesystem = $this->createMock(PrefixFilesystem::class);
-        $filesystem->expects(static::once())
+        $filesystem->expects($this->once())
             ->method('publicUrl')
             ->willReturn('https://localhost');
 
@@ -242,7 +242,7 @@ public function testMultipleGenerationsUseCachedExtensionAllowList(): void
             'ExtensionsAllowList' => 'jpg',
             'ThumbnailPattern' => '{mediaUrl}/{mediaPath}?width={width}',
         ];
-        $configReader->expects(static::exactly(3))
+        $configReader->expects($this->exactly(3))
             ->method('getConfig')
             ->willReturnCallback(function ($key) use ($defaultPluginConfig) {
                 return $defaultPluginConfig[$key] ?? null;
diff --git a/tests/unit/Core/Media/MediaUrlLoaderTest.php b/tests/unit/Core/Media/MediaUrlLoaderTest.php
diff --git a/tests/unit/Service/ThumbnailUrlTemplateTest.php b/tests/unit/Service/ThumbnailUrlTemplateTest.php

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ private function getProductFolderId(Context $context): string`
`83`	`83`	`->searchIds($criteria, $context)`
`84`	`84`	`->getIds();`
`85`	`85`
`86`		`- if (!empty($ids[0]) && \is_string($ids[0])) {`
	`86`	`+ if (isset($ids[0]) && \is_string($ids[0])) {`
`87`	`87`	`return $ids[0];`
`88`	`88`	`}`
`89`	`89`
`@@ -100,7 +100,7 @@ private function getSampleMedia(string $testFile): MediaEntity`
`100`	`100`	`$pathInfo = pathinfo($testFile);`
`101`	`101`
`102`	`102`	`$existingMedia = $this->getMediaById($pathInfo['filename'], $context);`
`103`		`- if ($existingMedia) {`
	`103`	`+ if ($existingMedia !== null) {`
`104`	`104`	`return $existingMedia;`
`105`	`105`	`}`
`106`	`106`
`@@ -130,7 +130,7 @@ private function getSampleMedia(string $testFile): MediaEntity`
`130`	`130`	`);`
`131`	`131`
`132`	`132`	`$existingMedia = $this->getMediaById($pathInfo['filename'], $context);`
`133`		`- if ($existingMedia) {`
	`133`	`+ if ($existingMedia !== null) {`
`134`	`134`	`return $existingMedia;`
`135`	`135`	`}`
`136`	`136`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ public function generate(array $paths): array`
`62`	`62`	`private function canProcess(string $path): bool`
`63`	`63`	`{`
`64`	`64`	`$fileExtension = \pathinfo($path, \PATHINFO_EXTENSION);`
`65`		`- \assert(\is_string($fileExtension));`
`66`	`65`
`67`	`66`	`return $this->canProcessFileExtension($fileExtension);`
`68`	`67`	`}`
`@@ -71,7 +70,7 @@ private function canProcessFileExtension(string $fileExtension): bool`
`71`	`70`	`{`
`72`	`71`	`$extensionsAllowList = $this->getExtensionsAllowList();`
`73`	`72`
`74`		`- if (empty($extensionsAllowList)) {`
	`73`	`+ if ($extensionsAllowList === []) {`
`75`	`74`	`return false;`
`76`	`75`	`}`
`77`	`76`
`@@ -101,7 +100,8 @@ private function getExtensionsAllowList(): array`
`101`	`100`	`\explode(`
`102`	`101`	`',',`
`103`	`102`	`(string) \preg_replace('/\s+/', '', \strtolower($extensionsAllowListConfig))`
`104`		`- )`
	`103`	`+ ),`
	`104`	`+ static fn($value) => $value !== ''`
`105`	`105`	`)`
`106`	`106`	`);`
`107`	`107`	`}`
`@@ -111,7 +111,7 @@ private function getExtensionsAllowList(): array`
`111`	`111`
`112`	`112`	`private function getWidth(string $maxWidth, UrlParams $value): string`
`113`	`113`	`{`
`114`		`- if ($value instanceof ExtendedUrlParams && !empty($value->width)) {`
	`114`	`+ if ($value instanceof ExtendedUrlParams && $value->width !== null && $value->width !== 0) {`
`115`	`115`	`return (string) $value->width;`
`116`	`116`	`}`
`117`	`117`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public function loaded(iterable $entities): void`
`18`	`18`	`{`
`19`	`19`	`$mapping = $this->map($entities);`
`20`	`20`
`21`		`- if (empty($mapping)) {`
	`21`	`+ if ($mapping !== []) {`
`22`	`22`	`return;`
`23`	`23`	`}`
`24`	`24`
`@@ -65,12 +65,12 @@ private function map(iterable $entities): array`
`65`	`65`	`$mapped = [];`
`66`	`66`
`67`	`67`	`foreach ($entities as $entity) {`
`68`		`- if (!$entity->has('path') \|\| empty($entity->get('path'))) {`
	`68`	`+ if (!$entity->has('path') \|\| $entity->get('path') === null \|\| $entity->get('path') === '') {`
`69`	`69`	`continue;`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`// don't generate private urls`
`73`		`- if (!$entity->has('private') \|\| $entity->get('private')) {`
	`73`	`+ if (!$entity->has('private') \|\| $entity->get('private') === true) {`
`74`	`74`	`continue;`
`75`	`75`	`}`
`76`	`76`
`@@ -91,7 +91,7 @@ private function map(iterable $entities): array`
`91`	`91`	`continue;`
`92`	`92`	`}`
`93`	`93`
`94`		`- if (!$thumbnail->has('path') \|\| empty($thumbnail->get('path'))) {`
	`94`	`+ if (!$thumbnail->has('path') \|\| $thumbnail->get('path') === null \|\| $thumbnail->get('path') === '') {`
`95`	`95`	`continue;`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function process(ContainerBuilder $container): void`
`34`	`34`	`{`
`35`	`35`	`$fileContents = $this->getFileContent();`
`36`	`36`
`37`		`- if (empty($fileContents)) {`
	`37`	`+ if ($fileContents === null \|\| $fileContents === '') {`
`38`	`38`	`$this->removeReflectionClass();`
`39`	`39`
`40`	`40`	`return;`
`@@ -71,7 +71,7 @@ public function process(ContainerBuilder $container): void`
`71`	`71`	`$doc = '/*' . \PHP_EOL . 'THIS CLASS HAS BEEN GENERATED AUTOMATICALLY' . \PHP_EOL . '/';`
`72`	`72`
`73`	`73`	`$existingDocs = $class->getDocComment()?->getText() ?? '';`
`74`		`- if (!empty($existingDocs)) {`
	`74`	`+ if ($existingDocs !== '') {`
`75`	`75`	`$doc .= \PHP_EOL . $existingDocs;`
`76`	`76`	`}`
`77`	`77`
`@@ -123,7 +123,7 @@ private function handleThumbnailService(NodeFinder $nodeFinder, array $ast): voi`
`123`	`123`	`$updateThumbnailsNode = $this->getClassMethod($nodeFinder, 'updateThumbnails', $ast);`
`124`	`124`
`125`	`125`	`$stmts = $updateThumbnailsNode->getStmts();`
`126`		`- if (empty($stmts)) {`
	`126`	`+ if ($stmts === null \|\| $stmts === []) {`
`127`	`127`	`throw new \RuntimeException(\sprintf('Method %s in class %s is empty', 'updateThumbnails', $this->class));`
`128`	`128`	`}`
`129`	`129`
`@@ -174,7 +174,7 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void`
`174`	`174`	`$filePath = $this->getFileName();`
`175`	`175`	`$files = glob(\dirname($filePath) . '/*.php');`
`176`	`176`
`177`		`- if (empty($files)) {`
	`177`	`+ if ($files === false \|\| $files === []) {`
`178`	`178`	`return;`
`179`	`179`	`}`
`180`	`180`
`@@ -188,7 +188,7 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void`
`188`	`188`	`$uses[] = new UseUse(new Name($class));`
`189`	`189`	`}`
`190`	`190`
`191`		`- if (empty($uses)) {`
	`191`	`+ if ($uses === []) {`
`192`	`192`	`return;`
`193`	`193`	`}`
`194`	`194`
`@@ -197,7 +197,13 @@ private function addUsesOfNamespace(?array &$stmts, string $namespace): void`
`197`	`197`
`198`	`198`	`private function getFileContent(): ?string`
`199`	`199`	`{`
`200`		`- return file_get_contents($this->getFileName()) ?: null;`
	`200`	`+ $content = file_get_contents($this->getFileName());`
	`201`	`+`
	`202`	`+ if (\is_string($content)) {`
	`203`	`+ return $content;`
	`204`	`+ }`
	`205`	`+`
	`206`	`+ return null;`
`201`	`207`	`}`
`202`	`208`
`203`	`209`	`private function getFileName(): string`
`@@ -206,7 +212,7 @@ private function getFileName(): string`
`206`	`212`
`207`	`213`	`$fileName = $reflectionClass->getFileName();`
`208`	`214`
`209`		`- if (empty($fileName)) {`
	`215`	`+ if ($fileName === false \|\| $fileName === '') {`
`210`	`216`	`throw new \RuntimeException(\sprintf('Cannot get fileName of class %s', $this->class));`
`211`	`217`	`}`
`212`	`218`
`@@ -231,7 +237,7 @@ private function getClassName(): string`
`231`	`237`	`{`
`232`	`238`	`$lastOccur = strrchr($this->class, '\\');`
`233`	`239`
`234`		`- if (empty($lastOccur)) {`
	`240`	`+ if ($lastOccur === false \|\| $lastOccur === '') {`
`235`	`241`	`throw new \RuntimeException(\sprintf('Cannot determine className from %s', $this->class));`
`236`	`242`	`}`
`237`	`243`
Original file line number	Diff line number	Diff line change
`@@ -36,14 +36,14 @@ public function onThumbnailSizeChanged(EntityWrittenEvent $event): void`
`36`	`36`	`foreach ($event->getWriteResults() as $writeResult) {`
`37`	`37`	`$mediaFolderConfigurationId = $writeResult->getPayload()['mediaFolderConfigurationId'] ?? null;`
`38`	`38`
`39`		`- if (!empty($mediaFolderConfigurationId) && \is_string($mediaFolderConfigurationId)) {`
	`39`	`+ if ($mediaFolderConfigurationId !== '' && \is_string($mediaFolderConfigurationId)) {`
`40`	`40`	`$updatedMediaFolderConfigurationIds[] = $mediaFolderConfigurationId;`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`$updatedMediaFolderConfigurationIds = \array_unique($updatedMediaFolderConfigurationIds);`
`45`	`45`
`46`		`- if (empty($updatedMediaFolderConfigurationIds)) {`
	`46`	`+ if ($updatedMediaFolderConfigurationIds === []) {`
`47`	`47`	`return;`
`48`	`48`	`}`
`49`	`49`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public function update(Connection $connection): void`
`16`	`16`	`{`
`17`	`17`	`$currentPluginVersion = $this->getPluginVersion($connection);`
`18`	`18`
`19`		`- if (empty($currentPluginVersion)) {`
	`19`	`+ if ($currentPluginVersion === null \|\| $currentPluginVersion === '') {`
`20`	`20`	`return;`
`21`	`21`	`}`
`22`	`22`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ private function isActive(mixed $config): bool`
`66`	`66`	`return true;`
`67`	`67`	`}`
`68`	`68`
`69`		`- return $this->isTestActive() \|\| !empty($config);`
	`69`	`+ return $this->isTestActive() \|\| ($config !== false && $config !== '0' && $config !== 0);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`private function isTestActive(): bool`
Original file line number	Diff line number	Diff line change
`@@ -13,9 +13,11 @@ public function __construct(`
`13`	`13`
`14`	`14`	`public function getUrl(string $mediaUrl, string $mediaPath, string $width, ?\DateTimeInterface $mediaUpdatedAt): string`
`15`	`15`	`{`
	`16`	`+ $timestamp = $mediaUpdatedAt !== null ? $mediaUpdatedAt->getTimestamp() : '0';`
	`17`	`+`
`16`	`18`	`return str_replace(`
`17`	`19`	`['{mediaUrl}', '{mediaPath}', '{width}', '{mediaUpdatedAt}'],`
`18`		`- [$mediaUrl, $mediaPath, $width, $mediaUpdatedAt?->getTimestamp() ?: '0'],`
	`20`	`+ [$mediaUrl, $mediaPath, $width, $timestamp],`
`19`	`21`	`$this->getPattern()`
`20`	`22`	`);`
`21`	`23`	`}`