fix: remove dependency config for twig warmer, enable it by default

Author: shyim

frosh-tools-schema.json

@@ -25,17 +25,6 @@
         "system_config": {
           "type": "object",
           "additionalProperties": true
-        },
-        "twig_cache_warmer": {
-          "type": "object",
-          "properties": {
-            "enabled": {
-              "title": "Enable Twig cache warmer during cache:warmup",
-              "type": "boolean",
-              "default": false
-            }
-          },
-          "additionalProperties": false
         }
       },
       "additionalProperties": false

src/Components/Twig/TwigCacheKernelWarmer.php

@@ -10,9 +10,7 @@
 class TwigCacheKernelWarmer implements CacheWarmerInterface
 {
     public function __construct(
-        private readonly TwigCacheWarmer $twigCacheWarmer,
-        #[Autowire('%frosh_tools.twig_cache_warmer.enabled%')]
-        private bool $enabled
+        private readonly TwigCacheWarmer $twigCacheWarmer
     ) {
     }
 
@@ -21,11 +19,15 @@ public function __construct(
      */
     public function warmUp(string $cacheDir, ?string $buildDir = null): array
     {
-        if (!$this->enabled) {
+        try {
+            return $this->twigCacheWarmer->warmUp($cacheDir);
+        } catch (\Throwable $e) {
+            if (\defined('STDERR')) {
+                fwrite(STDERR, 'Twig cache warming failed: ' . $e->getMessage() . PHP_EOL);
+            }
+
             return [];
         }
-
-        return $this->twigCacheWarmer->warmUp($cacheDir);
     }
 
     public function isOptional(): bool

src/DependencyInjection/Configuration.php

@@ -34,14 +34,6 @@ public function getConfigTreeBuilder(): TreeBuilder
                         ->end()
                     ->end()
                 ->end()
-                ->arrayNode('twig_cache_warmer')
-                    ->addDefaultsIfNotSet()
-                    ->children()
-                        ->booleanNode('enabled')
-                            ->defaultFalse()
-                        ->end()
-                    ->end()
-                ->end()
             ->end()
         ;