zend.detect_unicode is displayed as activated in the Frosh tool - although detect_unicode = Off is set in the PHP configuration

[benezln]

Question

Hello,

The Frosh tool recommends setting the PHP value zend.detect_unicode to 0. In the PHP configuration file of my Shopware installation, however, I can only find the entry:

detect_unicode = Off

As far as I know, this is the same setting, and Off should be equivalent to 0. Nevertheless, the Frosh tool still shows that zend.detect_unicode is active.

Can you please let me know if I might be missing something here? Or are there possibly several PHP configuration files so that the wrong one is loaded?

Beste Regards
Bene

[schneider-felix]

Well, I think I know what causes this. I don't know whether detect_unicode and zend.detect_unicode are actually the same (maybe @shyim knows?). But at least for the ini_get function, they are not.

The default value for zend.detect_unicode is null. Therefore iniGetFailover will return "not set"

FroshTools/src/Components/Health/Checker/PerformanceChecker/PhpSettingsChecker.php

Lines 103 to 111 in cd78ff0

	private function iniGetFailover(string $option): string
	{
	$currentValue = \ini_get($option);
	if (\is_string($currentValue)) {
	return $currentValue;
	}
	return 'not set';
	}

and this will cause filter_var to return true instead of false.

So we should probably change this iniGetFailover function or remove it entirely.