Merge pull request #1796 from deguif/static-closure

Use static closures when suitable

Author: XWB

src/Command/ProgressClosureBuilder.php

@@ -27,7 +27,7 @@ public static function build(OutputInterface $output, string $action, string $in
     {
         $progress = null;
 
-        return function ($increment, $totalObjects, $message = null) use (&$progress, $output, $action, $index, $offset) {
+        return static function ($increment, $totalObjects, $message = null) use (&$progress, $output, $action, $index, $offset) {
             if (null === $progress) {
                 $progress = new ProgressBar($output, $totalObjects);
                 $progress->start();

src/DependencyInjection/FOSElasticaExtension.php

@@ -658,7 +658,7 @@ private function loadTypeFinder(array $typeConfig, ContainerBuilder $container,
      */
     private function loadIndexManager(ContainerBuilder $container): void
     {
-        $indexRefs = \array_map(function ($index) {
+        $indexRefs = \array_map(static function ($index) {
             return $index['reference'];
         }, $this->indexConfigs);
 
@@ -671,7 +671,7 @@ private function loadIndexManager(ContainerBuilder $container): void
      */
     private function loadIndexTemplateManager(ContainerBuilder $container): void
     {
-        $indexTemplateRefs = \array_map(function ($index) {
+        $indexTemplateRefs = \array_map(static function ($index) {
             return $index['reference'];
         }, $this->indexTemplateConfigs);
 

src/Doctrine/AbstractElasticaToModelTransformer.php

@@ -92,7 +92,7 @@ public function transform(array $elasticaObjects)
         $propertyAccessor = $this->propertyAccessor;
         $identifier = $this->options['identifier'];
         if (!$this->options['ignore_missing'] && $objectsCnt < $elasticaObjectsCnt) {
-            $missingIds = \array_diff($ids, \array_map(function ($object) use ($propertyAccessor, $identifier) {
+            $missingIds = \array_diff($ids, \array_map(static function ($object) use ($propertyAccessor, $identifier) {
                 return $propertyAccessor->getValue($object, $identifier);
             }, $objects));
 

src/Paginator/RawPartialResults.php

@@ -31,7 +31,7 @@ public function __construct(ResultSet $resultSet)
      */
     public function toArray(): array
     {
-        return \array_map(function (Result $result) {
+        return \array_map(static function (Result $result) {
             return $result->getSource();
         }, $this->resultSet->getResults());
     }

src/Transformer/ModelToElasticaAutoTransformer.php

@@ -111,7 +111,7 @@ protected function transformNested($objects, array $fields)
      */
     protected function normalizeValue($value)
     {
-        $normalizeValue = function (&$v) {
+        $normalizeValue = static function (&$v) {
             if ($v instanceof \DateTimeInterface) {
                 $v = $v->format('c');
             } elseif (!\is_scalar($v) && null !== $v) {