Add extra validation for dynamically referenced services

In Symfony 4, services are private by default. But our registries are
still requiring to use public services for now, so this must be validated
to provide better error messages.

Author: stof

src/DependencyInjection/Compiler/RegisterPagerPersistersPass.php

@@ -29,7 +29,7 @@ public function process(ContainerBuilder $container)
         $registry = $container->getDefinition('fos_elastica.pager_persister_registry');
 
         $nameToServiceIdMap = [];
-        foreach ($container->findTaggedServiceIds('fos_elastica.pager_persister') as $id => $attributes) {
+        foreach ($container->findTaggedServiceIds('fos_elastica.pager_persister', true) as $id => $attributes) {
             foreach ($attributes as $attribute) {
                 if (!isset($attribute['persisterName'])) {
                     throw new \InvalidArgumentException(sprintf('Elastica pager persister "%s" must specify the "persisterName" attribute.', $id));
@@ -53,6 +53,10 @@ public function process(ContainerBuilder $container)
                     $this->assertClassImplementsPagerPersisterInterface($id, $container->getParameterBag()->resolveValue($persisterDef->getClass()));
                 }
 
+                if (!$persisterDef->isPublic()) {
+                    throw new \InvalidArgumentException(sprintf('Elastica pager persister "%s" must be a public service', $id));
+                }
+
                 $nameToServiceIdMap[$persisterName] = $id;
             }
         }

src/DependencyInjection/Compiler/RegisterPagerProvidersPass.php

@@ -30,7 +30,7 @@ public function process(ContainerBuilder $container)
         $registry = $container->getDefinition('fos_elastica.pager_provider_registry');
 
         $registeredProviders = [];
-        foreach ($container->findTaggedServiceIds('fos_elastica.pager_provider') as $id => $attributes) {
+        foreach ($container->findTaggedServiceIds('fos_elastica.pager_provider', true) as $id => $attributes) {
             foreach ($attributes as $attribute) {
                 if (!isset($attribute['type'])) {
                     throw new \InvalidArgumentException(sprintf('Elastica provider "%s" must specify the "type" attribute.', $id));
@@ -56,6 +56,10 @@ public function process(ContainerBuilder $container)
                     $this->assertClassImplementsPagerProviderInterface($id, $container->getParameterBag()->resolveValue($providerDef->getClass()));
                 }
 
+                if (!$providerDef->isPublic()) {
+                    throw new \InvalidArgumentException(sprintf('Elastica persister "%s" must be a public service', $id));
+                }
+
                 $registeredProviders[$index][$type] = $id;
             }
         }

src/DependencyInjection/Compiler/RegisterPersistersPass.php

@@ -30,7 +30,7 @@ public function process(ContainerBuilder $container)
         $registry = $container->getDefinition('fos_elastica.persister_registry');
 
         $registeredPersisters = [];
-        foreach ($container->findTaggedServiceIds('fos_elastica.persister') as $id => $attributes) {
+        foreach ($container->findTaggedServiceIds('fos_elastica.persister', true) as $id => $attributes) {
             foreach ($attributes as $attribute) {
                 if (!isset($attribute['type'])) {
                     throw new \InvalidArgumentException(sprintf('Elastica persister "%s" must specify the "type" attribute.', $id));
@@ -56,6 +56,10 @@ public function process(ContainerBuilder $container)
                     $this->assertClassImplementsPersisterInterface($id, $container->getParameterBag()->resolveValue($persisterDef->getClass()));
                 }
 
+                if (!$persisterDef->isPublic()) {
+                    throw new \InvalidArgumentException(sprintf('Elastica persister "%s" must be a public service', $id));
+                }
+
                 $registeredPersisters[$index][$type] = $id;
             }
         }