Remove automatic addition of store:true in mappings

Author: merk

CHANGELOG-3.1.md

@@ -9,6 +9,9 @@ https://github.com/FriendsOfSymfony/FOSElasticaBundle/commit/XXX where XXX is
 the commit hash. To get the diff between two versions, go to
 https://github.com/FriendsOfSymfony/FOSElasticaBundle/compare/v3.0.4...v3.1.0
 
+* 3.1.8 (Unreleased)
+ * Removes store:true from mappings unless specifically defined
+
 * 3.1.7 (2015-12-08)
  * Allow Elastica 2.3
 

Index/MappingBuilder.php

@@ -126,9 +126,6 @@ private function fixProperties(&$properties)
             if (in_array($property['type'], $this->skipTypes)) {
                 continue;
             }
-            if (!isset($property['store'])) {
-                $property['store'] = true;
-            }
         }
     }
 }

Tests/Index/MappingBuilderTest.php

@@ -0,0 +1,47 @@
+<?php
+
+namespace FOS\ElasticaBundle\Tests\Index;
+
+use FOS\ElasticaBundle\Configuration\TypeConfig;
+use FOS\ElasticaBundle\Index\MappingBuilder;
+
+class MappingBuilderTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @var MappingBuilder
+     */
+    private $builder;
+
+    protected function setUp()
+    {
+        $this->builder = new MappingBuilder();
+    }
+
+    public function testMappingBuilderStoreProperty()
+    {
+        $typeConfig = new TypeConfig('typename', [
+            'properties' => [
+                'storeless' => [
+                    'type' => 'string'
+                ],
+                'stored' => [
+                    'type' => 'string',
+                    'store' => true
+                ],
+                'unstored' => [
+                    'type' => 'string',
+                    'store' => false
+                ],
+            ]
+        ]);
+
+        $mapping = $this->builder->buildTypeMapping($typeConfig);
+
+        $this->assertArrayNotHasKey('store', $mapping['properties']['storeless']);
+        $this->assertArrayHasKey('store', $mapping['properties']['stored']);
+        $this->assertTrue($mapping['properties']['stored']['store']);
+        $this->assertArrayHasKey('store', $mapping['properties']['unstored']);
+        $this->assertFalse($mapping['properties']['unstored']['store']);
+    }
+
+}