Skip to content

Commit e565c39

Browse files
committed
Add type-hints to ResetterInterface
1 parent 2a8973d commit e565c39

File tree

3 files changed

+8
-14
lines changed

3 files changed

+8
-14
lines changed

src/Index/Resetter.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function __construct(
6363
/**
6464
* Deletes and recreates all indexes.
6565
*/
66-
public function resetAllIndexes(bool $populating = false, bool $force = false)
66+
public function resetAllIndexes(bool $populating = false, bool $force = false): void
6767
{
6868
foreach ($this->configManager->getIndexNames() as $name) {
6969
$this->resetIndex($name, $populating, $force);
@@ -76,7 +76,7 @@ public function resetAllIndexes(bool $populating = false, bool $force = false)
7676
*
7777
* @throws \InvalidArgumentException if no index exists for the given name
7878
*/
79-
public function resetIndex(string $indexName, bool $populating = false, bool $force = false)
79+
public function resetIndex(string $indexName, bool $populating = false, bool $force = false): void
8080
{
8181
$indexConfig = $this->configManager->getIndexConfiguration($indexName);
8282
$index = $this->indexManager->getIndex($indexName);
@@ -102,7 +102,7 @@ public function resetIndex(string $indexName, bool $populating = false, bool $fo
102102
*
103103
* @throws \FOS\ElasticaBundle\Exception\AliasIsIndexException
104104
*/
105-
public function switchIndexAlias(string $indexName, bool $delete = true)
105+
public function switchIndexAlias(string $indexName, bool $delete = true): void
106106
{
107107
$indexConfig = $this->configManager->getIndexConfiguration($indexName);
108108

src/Index/ResetterInterface.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,11 @@ interface ResetterInterface
2020
{
2121
/**
2222
* Reset all indexes.
23-
*
24-
* @return void
2523
*/
26-
public function resetAllIndexes();
24+
public function resetAllIndexes(): void;
2725

2826
/**
2927
* Reset index.
30-
*
31-
* @return void
3228
*/
33-
public function resetIndex(string $indexName);
29+
public function resetIndex(string $indexName): void;
3430
}

src/Index/TemplateResetter.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ class TemplateResetter implements ResetterInterface
3939
private $client;
4040

4141
/**
42-
* Index template manager.
43-
*
4442
* @var IndexTemplateManager
4543
*/
4644
private $indexTemplateManager;
@@ -57,14 +55,14 @@ public function __construct(
5755
$this->indexTemplateManager = $indexTemplateManager;
5856
}
5957

60-
public function resetAllIndexes($deleteIndexes = false)
58+
public function resetAllIndexes(bool $deleteIndexes = false): void
6159
{
6260
foreach ($this->configManager->getIndexNames() as $name) {
6361
$this->resetIndex($name, $deleteIndexes);
6462
}
6563
}
6664

67-
public function resetIndex(string $indexName, bool $deleteIndexes = false)
65+
public function resetIndex(string $indexName, bool $deleteIndexes = false): void
6866
{
6967
$indexTemplateConfig = $this->configManager->getIndexConfiguration($indexName);
7068
if (!$indexTemplateConfig instanceof IndexTemplateConfig) {
@@ -82,7 +80,7 @@ public function resetIndex(string $indexName, bool $deleteIndexes = false)
8280
/**
8381
* Delete all template indexes.
8482
*/
85-
public function deleteTemplateIndexes(IndexTemplateConfig $template)
83+
public function deleteTemplateIndexes(IndexTemplateConfig $template): void
8684
{
8785
$this->client->request($template->getTemplate().'/', Request::DELETE);
8886
}

0 commit comments

Comments
 (0)