Skip to content

Commit 2a8ec17

Browse files
committed
fix AppKernel and no longer skip symfony cache client tests with hhvm
1 parent 64c4acd commit 2a8ec17

File tree

2 files changed

+9
-18
lines changed

2 files changed

+9
-18
lines changed

tests/Functional/Fixtures/Symfony/AppKernel.php

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,18 @@
44

55
use Symfony\Component\HttpFoundation\Request;
66
use Symfony\Component\HttpFoundation\Response;
7-
use Symfony\Component\HttpKernel\HttpKernel;
87
use Symfony\Component\HttpKernel\HttpKernelInterface;
98

10-
class AppKernel extends HttpKernel
9+
/**
10+
* A simplistic kernel that is actually the whole application.
11+
*/
12+
class AppKernel implements HttpKernelInterface
1113
{
12-
public function __construct() {}
13-
14+
/**
15+
* This simplistic kernel handles the request immediately inline.
16+
*
17+
* {@inheritDoc}
18+
*/
1419
public function handle(Request $request, $type = HttpKernelInterface::MASTER_REQUEST, $catch = true)
1520
{
1621
switch ($request->getPathInfo()) {

tests/Functional/SymfonyProxyClientTest.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,6 @@
2020
*/
2121
class SymfonyProxyClientTest extends SymfonyTestCase
2222
{
23-
public function setUp()
24-
{
25-
/*
26-
* We did not figure out how to run this test with hhvm. Help welcome!
27-
* On travis, connection is closed after the headers are sent without providing
28-
* anything in either the hhvm or apache log.
29-
*/
30-
if (defined('HHVM_VERSION')) {
31-
$this->markTestSkipped('Test not working with hhvm as backend server');
32-
}
33-
34-
parent::setUp();
35-
}
36-
3723
public function testPurge()
3824
{
3925
$this->assertMiss($this->getResponse('/symfony.php/cache'));

0 commit comments

Comments
 (0)