Merge pull request #128 from lolautruche/fixHostHeader

Fix Host header for proxy client requests

Author: dbu

src/ProxyClient/AbstractProxyClient.php

@@ -161,11 +161,16 @@ private function sendRequests(array $requests)
         $allRequests = array();
 
         foreach ($requests as $request) {
+            $headers = $request->getHeaders()->toArray();
+            // Force to re-create Host header if empty, as Apache chokes on this. See #128 for discussion.
+            if (empty($headers['Host'])) {
+                unset( $headers['Host'] );
+            }
             foreach ($this->servers as $server) {
                 $proxyRequest = $this->client->createRequest(
                     $request->getMethod(),
                     $server . $request->getResource(),
-                    $request->getHeaders()
+                    $headers
                 );
                 $allRequests[] = $proxyRequest;
             }

tests/Unit/ProxyClient/VarnishTest.php

@@ -47,6 +47,23 @@ public function testBanEverything()
         $this->assertEquals('fos.lo', $headers->get('Host'));
     }
 
+    public function testBanEverythingNoBaseUrl()
+    {
+        $varnish = new Varnish(array('http://127.0.0.1:123'), null, $this->client);
+        $varnish->ban(array())->flush();
+
+        $requests = $this->getRequests();
+        $this->assertCount(1, $requests);
+        $this->assertEquals('BAN', $requests[0]->getMethod());
+
+        $headers = $requests[0]->getHeaders();
+        $this->assertEquals('.*', $headers->get('X-Host'));
+        $this->assertEquals('.*', $headers->get('X-Url'));
+        $this->assertEquals('.*', $headers->get('X-Content-Type'));
+        // Ensure host header matches the Varnish server one.
+        $this->assertEquals(array('127.0.0.1:123'), $headers->get('Host')->toArray());
+    }
+
     public function testBanHeaders()
     {
         $varnish = new Varnish(array('http://127.0.0.1:123'), 'fos.lo', $this->client);