use ::class constant over FQN string

Author: dbu

src/ResponseTagger.php

@@ -42,13 +42,14 @@ class ResponseTagger
     private $tags = [];
 
     /**
-     * Options for the constructor are:
+     * Create the response tagger with a tag capable proxy client and options.
+     *
+     * Supported options are:
      *
      * - strict (bool) Default: false. If set to true, throws exception when adding empty tags
      *
      * @param TagsInterface $proxyClient
      * @param array         $options
-     *
      */
     public function __construct(TagsInterface $proxyClient, array $options = array())
     {

tests/Unit/SymfonyCache/CustomTtlListenerTest.php

@@ -42,7 +42,7 @@ public function testCustomTtl()
         $ttlListener->useCustomTtl($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame('120', $response->headers->getCacheControlDirective('s-maxage'));
         $this->assertSame('60', $response->headers->get(CustomTtlListener::SMAXAGE_BACKUP));
     }
@@ -60,7 +60,7 @@ public function testCustomTtlNoSmaxage()
         $ttlListener->useCustomTtl($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame('120', $response->headers->getCacheControlDirective('s-maxage'));
         $this->assertSame('false', $response->headers->get(CustomTtlListener::SMAXAGE_BACKUP));
     }
@@ -79,7 +79,7 @@ public function testCleanup()
         $ttlListener->cleanResponse($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertTrue($response->headers->hasCacheControlDirective('s-maxage'));
         $this->assertSame('60', $response->headers->getCacheControlDirective('s-maxage'));
         $this->assertFalse($response->headers->has('X-Reverse-Proxy-TTL'));
@@ -100,7 +100,7 @@ public function testCleanupNoSmaxage()
         $ttlListener->cleanResponse($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertFalse($response->headers->hasCacheControlDirective('s_maxage'));
         $this->assertFalse($response->headers->has('X-Reverse-Proxy-TTL'));
         $this->assertFalse($response->headers->has(CustomTtlListener::SMAXAGE_BACKUP));

tests/Unit/SymfonyCache/DebugListenerTest.php

@@ -41,7 +41,7 @@ public function testDebugHit()
         $debugListener->handleDebug($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame('HIT', $response->headers->get('X-Cache'));
     }
 
@@ -57,7 +57,7 @@ public function testDebugMiss()
         $debugListener->handleDebug($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame('MISS', $response->headers->get('X-Cache'));
     }
 
@@ -73,7 +73,7 @@ public function testDebugUndefined()
         $debugListener->handleDebug($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame('UNDETERMINED', $response->headers->get('X-Cache'));
     }
 
@@ -87,7 +87,7 @@ public function testNoHeader()
         $debugListener->handleDebug($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertFalse($response->headers->has('X-Cache'));
     }
 }

tests/Unit/SymfonyCache/PurgeSubscriberTest.php

@@ -62,7 +62,7 @@ public function testPurgeAllowedMiss()
         $purgeSubscriber->handlePurge($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame(200, $response->getStatusCode());
     }
 
@@ -78,7 +78,7 @@ public function testPurgeForbiddenMatcher()
         $purgeSubscriber->handlePurge($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame(400, $response->getStatusCode());
     }
 
@@ -93,7 +93,7 @@ public function testPurgeForbiddenIp()
         $purgeSubscriber->handlePurge($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame(400, $response->getStatusCode());
     }
 

tests/Unit/SymfonyCache/UserContextSubscriberTest.php

@@ -70,7 +70,7 @@ public function testGenerateUserHashNotAllowed($arg, $options)
         $userContextSubscriber->preHandle($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame(400, $response->getStatusCode());
     }
 
@@ -88,7 +88,7 @@ public function testPassingUserHashNotAllowed($arg, $options)
         $userContextSubscriber->preHandle($event);
         $response = $event->getResponse();
 
-        $this->assertInstanceOf('Symfony\\Component\\HttpFoundation\\Response', $response);
+        $this->assertInstanceOf(Response::class, $response);
         $this->assertSame(400, $response->getStatusCode());
     }
 
@@ -206,14 +206,15 @@ public function testUserHashUserWithAuthorizationHeader($arg, $options)
             ->with(
                 \Mockery::on(
                     function (Request $request) use ($that, $hashRequest) {
-                    // we need to call some methods to get the internal fields initialized
-                    $request->getMethod();
-                    $request->getPathInfo();
-                    $that->assertEquals($hashRequest, $request);
-                    $that->assertCount(0, $request->cookies->all());
-
-                    return true;
-                })
+                        // we need to call some methods to get the internal fields initialized
+                        $request->getMethod();
+                        $request->getPathInfo();
+                        $that->assertEquals($hashRequest, $request);
+                        $that->assertCount(0, $request->cookies->all());
+
+                        return true;
+                    }
+                )
             )
             ->andReturn($hashResponse)
             ->getMock();