Skip to content

Commit e783f1b

Browse files
committed
make things private when possible
1 parent ee8a227 commit e783f1b

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

src/CacheInvalidator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,17 @@ class CacheInvalidator
4949
/**
5050
* @var ProxyClientInterface
5151
*/
52-
protected $cache;
52+
private $cache;
5353

5454
/**
5555
* @var EventDispatcherInterface
5656
*/
57-
protected $eventDispatcher;
57+
private $eventDispatcher;
5858

5959
/**
6060
* @var string
6161
*/
62-
protected $tagsHeader = 'X-Cache-Tags';
62+
private $tagsHeader = 'X-Cache-Tags';
6363

6464
/**
6565
* Constructor

src/Event.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
class Event extends BaseEvent
1717
{
18-
protected $exception;
18+
private $exception;
1919

2020
/**
2121
* Set exception

src/EventListener/LogSubscriber.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class LogSubscriber implements EventSubscriberInterface
2222
/**
2323
* @var LoggerInterface
2424
*/
25-
protected $logger;
25+
private $logger;
2626

2727
public function __construct(LoggerInterface $logger)
2828
{
@@ -50,7 +50,7 @@ public function onProxyResponseError(Event $event)
5050
$this->log(LogLevel::CRITICAL, $event->getException());
5151
}
5252

53-
protected function log($level, \Exception $exception)
53+
private function log($level, \Exception $exception)
5454
{
5555
$context = array(
5656
'exception' => $exception

src/Exception/ExceptionCollection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
*/
1818
class ExceptionCollection extends \Exception implements \IteratorAggregate, \Countable, HttpCacheExceptionInterface
1919
{
20-
protected $exceptions = array();
20+
private $exceptions = array();
2121

2222
/**
2323
* Add an exception to the collection

src/ProxyClient/AbstractProxyClient.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,21 @@ abstract class AbstractProxyClient implements ProxyClientInterface
3434
*
3535
* @var array
3636
*/
37-
protected $servers;
37+
private $servers;
3838

3939
/**
4040
* HTTP client
4141
*
4242
* @var ClientInterface
4343
*/
44-
protected $client;
44+
private $client;
4545

4646
/**
4747
* Request queue
4848
*
4949
* @var array|RequestInterface[]
5050
*/
51-
protected $queue;
51+
private $queue;
5252

5353
/**
5454
* Constructor
@@ -156,7 +156,7 @@ protected function createRequest($method, $url, array $headers = array())
156156
*
157157
* @throws ExceptionCollection
158158
*/
159-
protected function sendRequests(array $requests)
159+
private function sendRequests(array $requests)
160160
{
161161
$allRequests = array();
162162

src/ProxyClient/Nginx.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Nginx extends AbstractProxyClient implements PurgeInterface, RefreshInterf
3232
*
3333
* @var string|false
3434
*/
35-
protected $purgeLocation;
35+
private $purgeLocation;
3636

3737
/**
3838
* {@inheritdoc}

src/ProxyClient/Varnish.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Varnish extends AbstractProxyClient implements BanInterface, PurgeInterfac
3737
*
3838
* @var array
3939
*/
40-
protected $defaultBanHeaders = array(
40+
private $defaultBanHeaders = array(
4141
self::HTTP_HEADER_HOST => self::REGEX_MATCH_ALL,
4242
self::HTTP_HEADER_URL => self::REGEX_MATCH_ALL,
4343
self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL

0 commit comments

Comments
 (0)