Skip to content

Commit aff914d

Browse files
aminebenhariztobias-93
authored andcommitted
Add default value to absolute param (#308)
This will remove the IDE warning "expected 3 params" building files
1 parent a388a28 commit aff914d

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

Resources/js/router.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ class Router {
178178
* @param {boolean} absolute
179179
* @return {string}
180180
*/
181-
generate(name, opt_params, absolute) {
181+
generate(name, opt_params, absolute = false) {
182182
let route = (this.getRoute(name)),
183183
params = opt_params || {},
184184
unusedParams = Object.assign({}, params),

Resources/public/js/router.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,9 @@ var Router = function () {
237237

238238
}, {
239239
key: 'generate',
240-
value: function generate(name, opt_params, absolute) {
240+
value: function generate(name, opt_params) {
241+
var absolute = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : false;
242+
241243
var route = this.getRoute(name),
242244
params = opt_params || {},
243245
unusedParams = _extends({}, params),

Resources/public/js/router.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)