Skip to content

Commit c2d83e1

Browse files
willdurandGuilhemN
authored andcommitted
Fix js test suite
1 parent 1f0d91c commit c2d83e1

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
/composer.lock
33
/composer.phar
44
/vendor/
5+
/node_modules/
56
/.phpunit/

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ before_install:
3030

3131
install:
3232
- composer update $COMPOSER_FLAGS --prefer-dist
33+
- npm install google-closure-library
3334

3435
script:
3536
- ./phpunit

CONTRIBUTING.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,14 @@ $ ./phpunit
4646

4747
### JavaScript Test Suite
4848

49-
First, install [PhantomJS](http://phantomjs.org/) and then, execute this command:
49+
First, install [PhantomJS](http://phantomjs.org/) and [Google Closure
50+
Library](https://github.com/google/closure-library):
51+
52+
```bash
53+
$ npm install google-closure-library
54+
```
55+
56+
Run the JS test suite with:
5057

5158
```bash
5259
$ phantomjs Resources/js/run_jsunit.js Resources/js/router_test.html

Resources/js/router_test.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<title>Router Test</title>
66
</head>
77
<body>
8-
<script language="javascript" type="text/javascript" src="https://rawgit.com/google/closure-library/master/closure/goog/base.js"></script>
8+
<script language="javascript" type="text/javascript" src="../../node_modules/google-closure-library/closure/goog/base.js"></script>
99
<script language="javascript" type="text/javascript" src="router.js"></script>
1010
<script language="javascript" type="text/javascript" src="router.test.js"></script>
1111
</body>

0 commit comments

Comments
 (0)