The authorize form should be used only if authorize option true. (#554)

* The authorize form should be used only if authorize option true.

* add tests.

Author: makasim

DependencyInjection/FOSOAuthServerExtension.php

@@ -90,16 +90,16 @@ public function load(array $configs, ContainerBuilder $container)
 
         if (!empty($config['authorize'])) {
             $this->loadAuthorize($config['authorize'], $container, $loader);
-        }
 
-        // Authorize form factory definition
-        // TODO: Go back to xml configuration when bumping the requirement to Symfony >=2.6
-        $authorizeFormDefinition = $container->getDefinition('fos_oauth_server.authorize.form');
-        if (method_exists($authorizeFormDefinition, 'setFactory')) {
-            $authorizeFormDefinition->setFactory(array(new Reference('form.factory'), 'createNamed'));
-        } else {
-            $authorizeFormDefinition->setFactoryService('form.factory');
-            $authorizeFormDefinition->setFactoryMethod('createNamed');
+            // Authorize form factory definition
+            // TODO: Go back to xml configuration when bumping the requirement to Symfony >=2.6
+            $authorizeFormDefinition = $container->getDefinition('fos_oauth_server.authorize.form');
+            if (method_exists($authorizeFormDefinition, 'setFactory')) {
+                $authorizeFormDefinition->setFactory(array(new Reference('form.factory'), 'createNamed'));
+            } else {
+                $authorizeFormDefinition->setFactoryService('form.factory');
+                $authorizeFormDefinition->setFactoryMethod('createNamed');
+            }
         }
     }
 

Tests/DependencyInjection/FOSOAuthServerExtensionTest.php

@@ -11,11 +11,66 @@
 
 namespace DependencyInjection;
 
+use FOS\OAuthServerBundle\DependencyInjection\FOSOAuthServerExtension;
 use Symfony\Component\Config\FileLocator;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\Routing\Loader\XmlFileLoader;
 
 class FOSOAuthServerExtensionTest extends \PHPUnit_Framework_TestCase
 {
+    public function testShouldImplementConfigurationInterface()
+    {
+        $rc = new \ReflectionClass(FOSOAuthServerExtension::class);
+
+        $this->assertTrue($rc->isSubclassOf(Extension::class));
+    }
+
+    public function testCouldBeConstructedWithoutAnyArguments()
+    {
+        new FOSOAuthServerExtension();
+    }
+
+    public function testShouldLoadAuthorizeRelatedServicesIfAuthorizationIsEnabled()
+    {
+        $container = new ContainerBuilder();
+
+        $extension = new FOSOAuthServerExtension();
+        $extension->load([[
+            'db_driver' => 'orm',
+            'client_class' => 'aClientClass',
+            'access_token_class' => 'anAccessTokenClass',
+            'refresh_token_class' => 'aRefreshTokenClass',
+            'auth_code_class' => 'anAuthCodeClass',
+            'authorize' => true,
+        ]], $container);
+
+        $this->assertTrue($container->hasDefinition('fos_oauth_server.authorize.form'));
+        $this->assertTrue($container->hasDefinition('fos_oauth_server.authorize.form.type'));
+        $this->assertTrue($container->hasDefinition('fos_oauth_server.authorize.form.handler.default'));
+        $this->assertTrue($container->hasDefinition('fos_oauth_server.controller.authorize'));
+    }
+
+    public function testShouldNotLoadAuthorizeRelatedServicesIfAuthorizationIsDisabled()
+    {
+        $container = new ContainerBuilder();
+
+        $extension = new FOSOAuthServerExtension();
+        $extension->load([[
+            'db_driver' => 'orm',
+            'client_class' => 'aClientClass',
+            'access_token_class' => 'anAccessTokenClass',
+            'refresh_token_class' => 'aRefreshTokenClass',
+            'auth_code_class' => 'anAuthCodeClass',
+            'authorize' => false,
+        ]], $container);
+
+        $this->assertFalse($container->hasDefinition('fos_oauth_server.authorize.form'));
+        $this->assertFalse($container->hasDefinition('fos_oauth_server.authorize.form.type'));
+        $this->assertFalse($container->hasDefinition('fos_oauth_server.authorize.form.handler.default'));
+        $this->assertFalse($container->hasDefinition('fos_oauth_server.controller.authorize'));
+    }
+
     public function testLoadAuthorizeRouting()
     {
         $locator = new FileLocator();