infra: add PHPStan, CS Fixer to codebase

Author: dkarlovi

.php_cs

@@ -9,15 +9,6 @@
  * file that was distributed with this source code.
  */
 
-use Symfony\CS\Config\Config;
-use Symfony\CS\Finder\DefaultFinder;
-use Symfony\CS\Fixer\Contrib\HeaderCommentFixer;
-use Symfony\CS\FixerInterface;
-
-$finder = DefaultFinder::create()
-    ->in(__DIR__)
-;
-
 $header = <<<EOF
 This file is part of the FOSOAuthServerBundle package.
 
@@ -27,11 +18,53 @@ For the full copyright and license information, please view the LICENSE
 file that was distributed with this source code.
 EOF;
 
-HeaderCommentFixer::setHeader($header);
+$finder = PhpCsFixer\Finder::create()
+    ->exclude('vendor')
+    ->in(__DIR__);
 
-return Config::create()
-    ->level(FixerInterface::SYMFONY_LEVEL)
-    ->fixers(array('align_double_arrow', 'header_comment'))
-    ->finder($finder)
-    ->setUsingCache(true)
-;
+return PhpCsFixer\Config::create()
+    ->setRiskyAllowed(true)
+    ->setUsingCache(false)
+    ->setRules(
+        [
+            '@Symfony' => true,
+            '@PHPUnit60Migration:risky' => true,
+            'array_syntax' => ['syntax' => 'short'],
+            'combine_consecutive_unsets' => true,
+            'declare_strict_types' => true,
+            'dir_constant' => true,
+            'general_phpdoc_annotation_remove' => ['@author'],
+            'header_comment' => ['header' => $header],
+            'linebreak_after_opening_tag' => true,
+            'mb_str_functions' => true,
+            'modernize_types_casting' => true,
+            // 'native_function_invocation' => true,
+            'no_extra_consecutive_blank_lines' => ['continue', 'extra', 'return', 'throw', 'use', 'parenthesis_brace_block', 'square_brace_block', 'curly_brace_block'],
+            'no_multiline_whitespace_before_semicolons' => true,
+            'no_php4_constructor' => true,
+            'no_short_echo_tag' => true,
+            'no_unreachable_default_argument_value' => true,
+            'no_useless_else' => true,
+            'no_useless_return' => true,
+            'not_operator_with_space' => false,
+            'not_operator_with_successor_space' => false,
+            'ordered_class_elements' => true,
+            'ordered_imports' => true,
+            'php_unit_construct' => true,
+            'php_unit_strict' => true,
+            'phpdoc_add_missing_param_annotation' => true,
+            'phpdoc_annotation_without_dot' => true,
+            'phpdoc_inline_tag' => false,
+            'phpdoc_no_empty_return' => false,
+            'phpdoc_order' => true,
+            'phpdoc_to_comment' => false,
+            'psr4' => true,
+            'random_api_migration' => true,
+            'semicolon_after_instruction' => true,
+            'single_import_per_statement' => true,
+            'strict_comparison' => true,
+            'strict_param' => true,
+            'yoda_style' => false
+        ]
+    )
+    ->setFinder($finder);

Makefile

@@ -0,0 +1,21 @@
+QA_DOCKER_IMAGE=jakzal/phpqa:alpine
+QA_DOCKER_COMMAND=docker run -it --rm -v "$(shell pwd):/project" -w /project ${QA_DOCKER_IMAGE}
+
+dist: cs-full phpstan
+ci: cs-full-check phpstan
+lint: cs-full-check phpstan
+
+phpstan:
+	sh -c "${QA_DOCKER_COMMAND} phpstan analyse --configuration phpstan.neon --level 0 ."
+
+cs:
+	sh -c "${QA_DOCKER_COMMAND} php-cs-fixer fix -vvv --diff"
+
+cs-full:
+	sh -c "${QA_DOCKER_COMMAND} php-cs-fixer fix -vvv --using-cache=false --diff"
+
+cs-full-check:
+	sh -c "${QA_DOCKER_COMMAND} php-cs-fixer fix -vvv --using-cache=false --diff --dry-run"
+
+.PHONY: install install-dev install-lowest phpstan cs cs-full cs-full-checks docker-up down-down
+.PHONY: in-docker-install in-docker-install-dev in-docker-install-lowest in-docker-test in-docker-test-coverage

phpstan.neon

@@ -0,0 +1,5 @@
+parameters:
+    autoload_files:
+        - vendor/autoload.php
+    excludes_analyse:
+        - vendor/