~ fixed unit test for OAuthFactory to test with ChildDefinition or DefinitionDecorator, depending on what's available

Author: dinamic

Tests/DependencyInjection/Security/Factory/OAuthFactoryTest.php

@@ -4,6 +4,7 @@
 
 use FOS\OAuthServerBundle\DependencyInjection\Security\Factory\OAuthFactory;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
+use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\DefinitionDecorator;
@@ -39,6 +40,17 @@ public function testGetKey()
     }
 
     public function testCreate()
+    {
+        if (class_exists('Symfony\Component\DependencyInjection\DefinitionDecorator')) {
+            return $this->useDefinitionDecorator();
+        } elseif (class_exists('Symfony\Component\DependencyInjection\ChildDefinition')) {
+            return $this->useChildDefinition();
+        }
+
+        throw new \Exception('Neither DefinitionDecorator nor ChildDefinition exist');
+    }
+
+    protected function useDefinitionDecorator()
     {
         $container = $this->getMockBuilder(ContainerBuilder::class)
             ->disableOriginalConstructor()
@@ -91,6 +103,59 @@ public function testCreate()
         ], $this->instance->create($container, $id, $config, $userProvider, $defaultEntryPoint));
     }
 
+    protected function useChildDefinition()
+    {
+        $container = $this->getMockBuilder(ContainerBuilder::class)
+            ->disableOriginalConstructor()
+            ->setMethods([
+                'setDefinition',
+
+            ])
+            ->getMock()
+        ;
+        $id = '12';
+        $config = [];
+        $userProvider = 'mock.user.provider.service';
+        $defaultEntryPoint = '';
+
+        $definition = $this->getMockBuilder(Definition::class)
+            ->disableOriginalConstructor()
+            ->getMock()
+        ;
+
+        $container
+            ->expects($this->exactly(2))
+            ->method('setDefinition')
+            ->withConsecutive(
+                [
+                    'security.authentication.provider.fos_oauth_server.'. $id,
+                    new ChildDefinition('fos_oauth_server.security.authentication.provider')
+                ],
+                [
+                    'security.authentication.listener.fos_oauth_server.'. $id,
+                    new ChildDefinition('fos_oauth_server.security.authentication.listener')
+                ]
+            )
+            ->willReturnOnConsecutiveCalls(
+                $definition,
+                null
+            )
+        ;
+
+        $definition
+            ->expects($this->once())
+            ->method('replaceArgument')
+            ->with(0, new Reference($userProvider))
+            ->willReturn(null)
+        ;
+
+        $this->assertSame([
+            'security.authentication.provider.fos_oauth_server.'. $id,
+            'security.authentication.listener.fos_oauth_server.'. $id,
+            'fos_oauth_server.security.entry_point'
+        ], $this->instance->create($container, $id, $config, $userProvider, $defaultEntryPoint));
+    }
+
     public function testAddConfigurationDoesNothing()
     {
         $nodeDefinition = $this->getMockBuilder(NodeDefinition::class)