Get the current OAuth client

[pierrre]

Is it possible to get the current oauth client?
I can't find a way to do it properly.

Here is my idea:

• Add a client field in FOS\OAuthServerBundle\Security\Authentication\Token\OAuthToken
• Edit FOS\OAuthServerBundle\Security\Authentication\Provider\OAuthProvider and set the client in OAuthToken

Is it ok?

[pierrre]

Can I send a pull request?

[adrienbrault]

@pierre Why don't you "just" do this :

$token = $securityContext->getToken()->getToken();
$accessToken = $accessTokenManager->findTokenBy(array('token' => $token));
$client = $accessToken->getClient();

[pierrre]

It does 1 additional request in the database:

$accessToken = $accessTokenManager->findTokenBy(array('token' => $token));
Is useless if we set the client in FOS\OAuthServerBundle\Security\Authentication\Token\OAuthToken

[willdurand]

Yes, why not. I think it can be useful.

[pierrre]

Actually, we should store the access token (doctrine document/entity) as an object in the oauth security token.
Currently, it's a string.

[AlmogBaku]

I agree, storing this info on the token entity sounds more efficient.
cc: @willdurand what do you think?

I can work on PR if you think its relevant

[AlmogBaku]

Why doesn't https://github.com/FriendsOfSymfony/FOSOAuthServerBundle/tree/feature/client-on-token merged to the master?

[dkarlovi]

There's a branch in the bundle, there's #188, why hasn't this been merged yet? /cc @GuilhemN

[GuilhemN]

Sorry I don't have the time to review this bundle's PRs anymore... But I can add you as collaborator if you're willing to maintain this bundle.

[dkarlovi]

I'll do my best, let's do it. 👍

[GuilhemN]

Done :)

[dkarlovi]

Thinking about this, we shouldn't set the client, instead we should inject the whole token instead of only the string. Will work on this for 2.0.