bug #1840 make the view handler alias public (xabbuh)

This PR was merged into the 2.3-dev branch.

Discussion
----------

make the view handler alias public

The alias will be fetched from the container when using the built-in
FOSRestController class. Thus, we must ensure that it can still be
located when using Symfony 4.0 or higher.

Commits
-------

14d9c48 make the view handler alias public

Author: xabbuh

DependencyInjection/FOSRestExtension.php

@@ -12,6 +12,7 @@
 namespace FOS\RestBundle\DependencyInjection;
 
 use Symfony\Component\Config\FileLocator;
+use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -68,7 +69,11 @@ public function load(array $configs, ContainerBuilder $container)
             }
 
             if (null !== $service) {
-                $container->setAlias('fos_rest.'.$key, $service);
+                if ('view_handler' === $key) {
+                    $container->setAlias('fos_rest.'.$key, new Alias($service, true));
+                } else {
+                    $container->setAlias('fos_rest.'.$key, $service);
+                }
             }
         }
 

Tests/DependencyInjection/FOSRestExtensionTest.php

@@ -13,6 +13,7 @@
 
 use FOS\RestBundle\DependencyInjection\FOSRestExtension;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
@@ -238,6 +239,14 @@ public function testLoadServicesWithDefaults()
         $this->extension->load([], $this->container);
 
         $this->assertAlias('fos_rest.view_handler.default', 'fos_rest.view_handler');
+
+        $viewHandlerAlias = $this->container->getAlias('fos_rest.view_handler');
+
+        $this->assertTrue($viewHandlerAlias->isPublic());
+
+        if (method_exists(Alias::class, 'isPrivate')) {
+            $this->assertFalse($viewHandlerAlias->isPrivate());
+        }
     }
 
     public function testDisableViewResponseListener()