mark legacy aliases as deprecated

Author: xabbuh

DependencyInjection/FOSRestExtension.php

@@ -84,7 +84,7 @@ public function load(array $configs, ContainerBuilder $container)
             if (null !== $service) {
                 if ('view_handler' === $key) {
                     $container->setAlias('fos_rest.'.$key, new Alias($service, true));
-                } elseif('templating' === $key) {
+                } elseif(in_array($key, ['inflector', 'router', 'templating'], true)) {
                     $alias = new Alias($service);
 
                     if (method_exists($alias, 'setDeprecated')) {
@@ -355,7 +355,7 @@ private function loadView(array $config, XmlFileLoader $loader, ContainerBuilder
         $defaultViewHandler = $container->getDefinition('fos_rest.view_handler.default');
 
         $defaultViewHandler->setArguments([
-            new Reference('fos_rest.router'),
+            new Reference($config['service']['router']),
             new Reference('fos_rest.serializer'),
             new Reference('fos_rest.templating', ContainerInterface::NULL_ON_INVALID_REFERENCE),
             new Reference('request_stack'),

Tests/DependencyInjection/FOSRestExtensionTest.php

@@ -1160,4 +1160,17 @@ public function testRegisterSerializerErrorRenderer()
         $this->assertTrue($this->container->hasAlias('error_renderer'));
         $this->assertSame('fos_rest.error_renderer.serializer', (string) $this->container->getAlias('error_renderer'));
     }
+
+    public function testLegacyAliasesAreDeprecated()
+    {
+        if (!method_exists(Alias::class, 'isDeprecated')) {
+            $this->markTestSkipped();
+        }
+
+        $this->extension->load([], $this->container);
+
+        $this->assertTrue($this->container->getAlias('fos_rest.inflector')->isDeprecated());
+        $this->assertTrue($this->container->getAlias('fos_rest.router')->isDeprecated());
+        $this->assertTrue($this->container->getAlias('fos_rest.templating')->isDeprecated());
+    }
 }