Skip to content

Commit 3fb2d30

Browse files
committed
fix regression with handling of methods in Route annotations
1 parent ecff055 commit 3fb2d30

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

Controller/Annotations/Route.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ public function __construct(array $data)
2323
{
2424
parent::__construct($data);
2525

26-
$this->setMethods((array) $this->getMethod());
26+
if (!$this->getMethods()) {
27+
$this->setMethods((array) $this->getMethod());
28+
}
2729
}
2830

2931
/**

Tests/Fixtures/Controller/AnnotatedConditionalUsersController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ public function rateUserAction($slug)
7171
{} // [POST] /users/{slug}/rate
7272

7373
/**
74-
* @Route("/users/{slug}/rate_comment/{id}", requirements={"slug" = "[a-z]+", "id" = "\d+"}, methods={"PATCH, POST"})
74+
* @Route("/users/{slug}/rate_comment/{id}", requirements={"slug" = "[a-z]+", "id" = "\d+"}, methods={"PATCH", "POST"})
7575
*/
7676
public function rateUserCommentAction($slug, $id)
77-
{} // [POST] /users/{slug}/rate_comment/{id}
77+
{} // [PATCH, POST] /users/{slug}/rate_comment/{id}
7878

7979
/**
8080
* @Get

Tests/Fixtures/Controller/AnnotatedUsersController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ public function rateUserAction($slug)
7777
{} // [POST] /users/{slug}/rate
7878

7979
/**
80-
* @Route("/users/{slug}/rate_comment/{id}", requirements={"slug" = "[a-z]+", "id" = "\d+"})
80+
* @Route("/users/{slug}/rate_comment/{id}", requirements={"slug" = "[a-z]+", "id" = "\d+"}, methods={"PATCH", "POST"})
8181
*/
8282
public function rateUserCommentAction($slug, $id)
83-
{} // [POST] /users/{slug}/rate_comment/{id}
83+
{} // [PATCH, POST] /users/{slug}/rate_comment/{id}
8484

8585
/**
8686
* @Get

Tests/Fixtures/Etalon/annotated_conditional_controller.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ rate_user_comment:
3636
path: /users/{slug}/rate_comment/{id}.{_format}
3737
controller: ::rateUserCommentAction
3838
requirements: {slug: '[a-z]+', id: '\d+'}
39-
methods: [PATCH]
39+
methods: [PATCH, POST]
4040

4141
bget_user:
4242
path: /users/{slug}/bget.{_format}

0 commit comments

Comments
 (0)