#718 - XML route options

Author: egulias

Routing/Loader/RestXmlCollectionLoader.php

@@ -103,6 +103,18 @@ protected function parseNode(RouteCollection $collection, \DOMElement $node, $pa
      */
     protected function parseRoute(RouteCollection $collection, \DOMElement $node, $path)
     {
+        foreach ($node->childNodes as $child) {
+            if ($child instanceof \DOMElement && $child->tagName === 'option') {
+                $option = $node->ownerDocument->createElementNs(
+                    self::NAMESPACE_URI,
+                    'option',
+                    $child->nodeValue
+                );
+                $option->setAttribute('key', $child->getAttribute('key'));
+                $node->appendChild($option);
+            }
+        }
+
         // the Symfony Routing component uses a path attribute since Symfony 2.2
         // instead of the deprecated pattern attribute0
         if (!$node->hasAttribute('path')) {

Tests/Fixtures/Routes/routes_with_options.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<routes xmlns="http://friendsofsymfony.github.com/schema/rest"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://friendsofsymfony.github.com/schema/rest
+        http://friendsofsymfony.github.com/schema/rest/routing-1.0.xsd"
+>
+    <route id="get_users" pattern="/users">
+        <default key="_controller">FOSRestBundle:UsersController:getUsers</default>
+        <option key="expose">true</option>
+    </route>
+</routes>

Tests/Routing/Loader/RestXmlCollectionLoaderTest.php

@@ -108,6 +108,23 @@ public function testManualRoutesWithDefaultFormat()
         $this->assertEquals('xml', $route->getDefault('_format'));
     }
 
+    public function testForwardOptions()
+    {
+        $collection = $this->loadFromXmlCollectionFixture(
+            'routes_with_options.xml',
+            true,
+            array(
+                'json' => false,
+                'xml'  => false,
+                'html' => true,
+            ),
+            'xml'
+        );
+
+        foreach ($collection as $route) {
+            $this->assertTrue($route->getOption('expose'));
+        }
+    }
     /**
      * Load routes collection from XML fixture routes under Tests\Fixtures directory.
      *