bug #2178 Throw exception for false combination of twig exception controller and exception_listener configuration (alexander-schranz)

This PR was squashed before being merged into the 2.x branch (closes #2178).

Discussion
----------

Throw exception for false combination of twig exception controller and exception_listener configuration

By default in symfony 4.4 the older exception controller is used so the error handler component is not used. If the exceptionListener is disabled the newer ErrorController need to be used else the mapping configuraiton and listeners don't work.

This would fix #2167 (comment) where on `prefer-lowest` and disabled `exception_listener` the error handler is not called and so the exception not correctly serialized

Commits
-------

e54a336 Throw exception for false combination of twig exception controller and exception_listener configuration

Author: xabbuh

DependencyInjection/Compiler/TwigExceptionPass.php

@@ -24,6 +24,14 @@ final class TwigExceptionPass implements CompilerPassInterface
 {
     public function process(ContainerBuilder $container)
     {
+        if ($container->hasDefinition('fos_rest.exception.codes_map') // is config exception.enabled true
+            && $container->hasParameter('twig.exception_listener.controller') // is twig-bundle 4.4 installed
+            && $container->getParameter('twig.exception_listener.controller') // is twig-bundle deprecated controller set
+            && !$container->hasDefinition('fos_rest.exception_listener') // is deprecated exception_listener disabled
+        ) {
+            throw new \InvalidArgumentException('You can not disable the "fos_rest.exception.exception_listener" and still have the "twig.exception_controller" enabled.');
+        }
+
         // when no custom exception controller has been set
         if ($container->hasDefinition('fos_rest.error_listener') &&
             null === $container->getDefinition('fos_rest.error_listener')->getArgument(0)

Tests/Functional/app/RequestBodyParamConverterTwigBundle/config.yml

@@ -11,8 +11,6 @@ framework:
 fos_rest:
     body_converter:
         enabled: true
-    exception:
-        exception_listener: false
     routing_loader: false
 
 sensio_framework_extra: