Skip to content

Commit c7a4615

Browse files
committed
Fix noop call of deprecated setAccessible() in PHP > 8.0
1 parent d71a83c commit c7a4615

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

Tests/Negotiation/FormatNegotiatorTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,9 @@ public function testGetBestWithPreferExtension()
112112

113113
$reflectionClass = new \ReflectionClass(get_class($this->request));
114114
$reflectionProperty = $reflectionClass->getProperty('pathInfo');
115-
$reflectionProperty->setAccessible(true);
115+
if (PHP_VERSION_ID < 80100) {
116+
$reflectionProperty->setAccessible(true);
117+
}
116118
$reflectionProperty->setValue($this->request, '/file.json');
117119

118120
// Without extension mime-type in Accept header
@@ -135,7 +137,9 @@ public function testGetBestWithPreferExtensionAndUnknownExtension()
135137

136138
$reflectionClass = new \ReflectionClass(get_class($this->request));
137139
$reflectionProperty = $reflectionClass->getProperty('pathInfo');
138-
$reflectionProperty->setAccessible(true);
140+
if (PHP_VERSION_ID < 80100) {
141+
$reflectionProperty->setAccessible(true);
142+
}
139143
$reflectionProperty->setValue($this->request, '/file.123456789');
140144

141145
$this->request->headers->set('Accept', 'text/html, application/json');

Tests/Request/RequestBodyParamConverterTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ public function testContextConfiguration()
194194
];
195195

196196
$contextConfigurationMethod = new \ReflectionMethod($converter, 'configureContext');
197-
$contextConfigurationMethod->setAccessible(true);
197+
if (PHP_VERSION_ID < 80100) {
198+
$contextConfigurationMethod->setAccessible(true);
199+
}
198200
$contextConfigurationMethod->invoke($converter, $context = new Context(), $options);
199201

200202
$expectedContext = new Context();
@@ -225,7 +227,9 @@ public function testValidatorOptionsGetter()
225227
];
226228

227229
$validatorMethod = new \ReflectionMethod($converter, 'getValidatorOptions');
228-
$validatorMethod->setAccessible(true);
230+
if (PHP_VERSION_ID < 80100) {
231+
$validatorMethod->setAccessible(true);
232+
}
229233
$this->assertEquals(['groups' => ['foo'], 'traverse' => true, 'deep' => false], $validatorMethod->invoke($converter, $options1));
230234
$this->assertEquals(['groups' => false, 'traverse' => false, 'deep' => true], $validatorMethod->invoke($converter, $options2));
231235
}

Tests/View/ViewHandlerTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,9 @@ public function testSerializeNullDataValues($expected, $serializeNull)
308308
$viewHandler->setSerializeNullStrategy($serializeNull);
309309

310310
$contextMethod = new \ReflectionMethod($viewHandler, 'getSerializationContext');
311-
$contextMethod->setAccessible(true);
311+
if (PHP_VERSION_ID < 80100) {
312+
$contextMethod->setAccessible(true);
313+
}
312314

313315
$view = new View();
314316
$context = $contextMethod->invoke($viewHandler, $view);
@@ -384,7 +386,9 @@ public function testConfigurableViewHandlerInterface()
384386
$viewHandler->setSerializeNullStrategy(true);
385387

386388
$contextMethod = new \ReflectionMethod($viewHandler, 'getSerializationContext');
387-
$contextMethod->setAccessible(true);
389+
if (PHP_VERSION_ID < 80100) {
390+
$contextMethod->setAccessible(true);
391+
}
388392

389393
$view = new View();
390394
$context = $contextMethod->invoke($viewHandler, $view);

0 commit comments

Comments
 (0)