tag attribute depends on the Form component version (#1598)

Author: xabbuh

DependencyInjection/FOSRestExtension.php

@@ -16,6 +16,8 @@
 use Symfony\Component\DependencyInjection\DefinitionDecorator;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\HttpFoundation\Response;
 
@@ -88,7 +90,16 @@ private function loadForm(array $config, XmlFileLoader $loader, ContainerBuilder
     {
         if (!empty($config['disable_csrf_role'])) {
             $loader->load('forms.xml');
-            $container->getDefinition('fos_rest.form.extension.csrf_disable')->replaceArgument(1, $config['disable_csrf_role']);
+
+            $definition = $container->getDefinition('fos_rest.form.extension.csrf_disable');
+            $definition->replaceArgument(1, $config['disable_csrf_role']);
+
+            // BC for Symfony < 2.8: the extended_type attribute is used on higher versions
+            if (!method_exists(AbstractType::class, 'getBlockPrefix')) {
+                $definition->addTag('form.type_extension', ['alias' => 'form']);
+            } else {
+                $definition->addTag('form.type_extension', ['extended_type' => FormType::class]);
+            }
         }
     }
 

Resources/config/forms.xml

@@ -6,8 +6,6 @@
 
     <services>
         <service id="fos_rest.form.extension.csrf_disable" class="FOS\RestBundle\Form\Extension\DisableCSRFExtension">
-            <!-- "alias" option for SF <2.8 -->
-            <tag name="form.type_extension" alias="form" extended-type="Symfony\Component\Form\Extension\Core\Type\FormType" />
             <argument type="service" id="security.token_storage" />
             <argument /> <!-- disable CSRF role -->
             <argument type="service" id="security.authorization_checker" />