Add support for SameSite cookie session setting

Author: mentalstring

lib/response/sfWebResponse.class.php

@@ -161,18 +161,18 @@ public function isHeaderOnly()
     /**
      * Sets a cookie.
      *
-     * @param string $name     HTTP header name
-     * @param string $value    Value for the cookie
-     * @param string $expire   Cookie expiration period
-     * @param string $path     Path
-     * @param string $domain   Domain name
-     * @param bool   $secure   If secure
-     * @param bool   $httpOnly If uses only HTTP
-     * @param bool   $samesite If uses Same-site cookies
+     * @param string                   $name     HTTP header name
+     * @param string                   $value    Value for the cookie
+     * @param string                   $expire   Cookie expiration period
+     * @param string                   $path     Path
+     * @param string                   $domain   Domain name
+     * @param bool                     $secure   If secure
+     * @param bool                     $httpOnly If uses only HTTP
+     * @param ''|'None'|'Lax'|'Strict' $samesite If uses Same-site cookies
      *
      * @throws sfException If fails to set the cookie
      */
-    public function setCookie($name, $value, $expire = null, $path = '/', $domain = '', $secure = false, $httpOnly = false, $samesite = '')
+    public function setCookie($name, $value, $expire = null, $path = '/', $domain = '', $secure = false, $httpOnly = false, string $samesite = '')
     {
         if (null !== $expire) {
             if (is_numeric($expire)) {

lib/storage/sfSessionStorage.class.php

@@ -82,14 +82,13 @@ public function initialize($options = null)
         $samesite = $this->options['session_cookie_samesite'];
         session_set_cookie_params([
             'lifetime' => $lifetime,
-            'path'     => $path,
-            'domain'   => $domain,
-            'secure'   => $secure,
+            'path' => $path,
+            'domain' => $domain,
+            'secure' => $secure,
             'httponly' => $httpOnly,
             'samesite' => $samesite,
         ]);
 
-
         if (null !== $this->options['session_cache_limiter']) {
             session_cache_limiter($this->options['session_cache_limiter']);
         }