[TASK] Make classes readonly where possible

nhovratov · nhovratov · commit 7fb0c2a7cd40 · 2025-12-20T14:24:27.000+01:00
(cherry picked from commit eb30120)
diff --git a/Classes/Backend/Preview/RootPathsSettings.php b/Classes/Backend/Preview/RootPathsSettings.php
@@ -22,7 +22,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class RootPathsSettings
+readonly class RootPathsSettings
 {
     /**
      * @return array<int, string>
diff --git a/Classes/Builder/ConfigBuilder.php b/Classes/Builder/ConfigBuilder.php
@@ -20,7 +20,7 @@
 use TYPO3\CMS\ContentBlocks\Definition\ContentType\ContentType;
 use TYPO3\CMS\ContentBlocks\Definition\Factory\UniqueIdentifierCreator;
 
-class ConfigBuilder
+readonly class ConfigBuilder
 {
     public function build(ContentType $contentType, string $vendor, string $name, ?string $title, null|string|int $typeName, array $defaultConfig): array
     {
diff --git a/Classes/Builder/DefaultsLoader.php b/Classes/Builder/DefaultsLoader.php
@@ -21,7 +21,7 @@
 use Symfony\Component\Yaml\Yaml;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-class DefaultsLoader
+readonly class DefaultsLoader
 {
     /**
      * @return array{
diff --git a/Classes/DataProcessing/GridFactory.php b/Classes/DataProcessing/GridFactory.php
@@ -27,7 +27,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class GridFactory
+readonly class GridFactory
 {
     /**
      * @param array<ContentBlockData> $records
diff --git a/Classes/DataProcessing/GridProcessor.php b/Classes/DataProcessing/GridProcessor.php
@@ -24,10 +24,10 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class GridProcessor
+readonly class GridProcessor
 {
     public function __construct(
-        protected readonly GridFactory $gridFactory,
+        protected GridFactory $gridFactory,
     ) {}
 
     public function processGrid(
diff --git a/Classes/Definition/Factory/TcaFieldFactory.php b/Classes/Definition/Factory/TcaFieldFactory.php
@@ -22,7 +22,7 @@
 use TYPO3\CMS\ContentBlocks\Definition\TcaFieldDefinition;
 use TYPO3\CMS\ContentBlocks\FieldType\FieldTypeInterface;
 
-class TcaFieldFactory
+readonly class TcaFieldFactory
 {
     public static function create(array $array): TcaFieldDefinition
     {
diff --git a/Classes/Definition/Factory/UniqueIdentifierCreator.php b/Classes/Definition/Factory/UniqueIdentifierCreator.php
@@ -22,7 +22,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class UniqueIdentifierCreator
+readonly class UniqueIdentifierCreator
 {
     public static function createContentTypeIdentifier(string $name): string
     {
diff --git a/Classes/Form/FormDataProvider/AllowedRecordTypeFilter.php b/Classes/Form/FormDataProvider/AllowedRecordTypeFilter.php
@@ -22,7 +22,7 @@
 /**
  * @internal
  */
-class AllowedRecordTypeFilter
+readonly class AllowedRecordTypeFilter
 {
     /**
      * @param array<array|SelectItem> $items
diff --git a/Classes/Generator/HtmlTemplateCodeGenerator.php b/Classes/Generator/HtmlTemplateCodeGenerator.php
@@ -23,7 +23,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class HtmlTemplateCodeGenerator
+readonly class HtmlTemplateCodeGenerator
 {
     public function generateEditorPreviewTemplate(LoadedContentBlock $contentBlockConfiguration): string
     {
diff --git a/Classes/Loader/AssetPublisher.php b/Classes/Loader/AssetPublisher.php
@@ -22,7 +22,7 @@
 use TYPO3\CMS\ContentBlocks\Utility\ContentBlockPathUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
-class AssetPublisher
+readonly class AssetPublisher
 {
     /**
      * @param LoadedContentBlock[] $loadedContentBlocks
diff --git a/Classes/Schema/FieldTypeResolver.php b/Classes/Schema/FieldTypeResolver.php
@@ -23,7 +23,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class FieldTypeResolver
+readonly class FieldTypeResolver
 {
     public function __construct(
         protected BaseFieldTypeRegistry $baseFieldTypeRegistry,
diff --git a/Classes/Service/Icon/ContentTypeIconResolver.php b/Classes/Service/Icon/ContentTypeIconResolver.php
@@ -27,7 +27,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class ContentTypeIconResolver
+readonly class ContentTypeIconResolver
 {
     public static function resolve(ContentTypeIconResolverInput $input): ?ContentTypeIcon
     {
diff --git a/Classes/Service/PackageResolver.php b/Classes/Service/PackageResolver.php
@@ -27,7 +27,7 @@
  *
  * @internal Not part of TYPO3's public API.
  */
-class PackageResolver
+readonly class PackageResolver
 {
     public function __construct(protected PackageManager $packageManager) {}
 
diff --git a/Classes/Utility/ContentBlockPathUtility.php b/Classes/Utility/ContentBlockPathUtility.php
@@ -23,7 +23,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class ContentBlockPathUtility
+readonly class ContentBlockPathUtility
 {
     public static function getContentBlockExtPath(string $extensionKey, string $contentBlockFolderName, ContentType $contentType): string
     {
diff --git a/Classes/Utility/LocalLangPathUtility.php b/Classes/Utility/LocalLangPathUtility.php
@@ -20,7 +20,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class LocalLangPathUtility
+readonly class LocalLangPathUtility
 {
     public static function extractKeyFromLLLPath(string $key): string
     {
diff --git a/Classes/Validation/ContentBlockNameValidator.php b/Classes/Validation/ContentBlockNameValidator.php
@@ -20,7 +20,7 @@
 /**
  * @internal Not part of TYPO3's public API.
  */
-class ContentBlockNameValidator
+readonly class ContentBlockNameValidator
 {
     public static function isValid(string $name): bool
     {
diff --git a/Tests/Unit/Fixtures/FieldTypeRegistryTestFactory.php b/Tests/Unit/Fixtures/FieldTypeRegistryTestFactory.php
@@ -49,7 +49,7 @@
 use TYPO3\CMS\ContentBlocks\FieldType\TextFieldType;
 use TYPO3\CMS\ContentBlocks\FieldType\UuidFieldType;
 
-class FieldTypeRegistryTestFactory
+readonly class FieldTypeRegistryTestFactory
 {
     public static function create(): FieldTypeRegistry
     {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`/**`
`23`	`23`	`* @internal Not part of TYPO3's public API.`
`24`	`24`	`*/`
`25`		`-class RootPathsSettings`
	`25`	`+readonly class RootPathsSettings`
`26`	`26`	`{`
`27`	`27`	`/**`
`28`	`28`	`* @return array<int, string>`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`use TYPO3\CMS\ContentBlocks\Definition\ContentType\ContentType;`
`21`	`21`	`use TYPO3\CMS\ContentBlocks\Definition\Factory\UniqueIdentifierCreator;`
`22`	`22`
`23`		`-class ConfigBuilder`
	`23`	`+readonly class ConfigBuilder`
`24`	`24`	`{`
`25`	`25`	`public function build(ContentType $contentType, string $vendor, string $name, ?string $title, null\|string\|int $typeName, array $defaultConfig): array`
`26`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`use Symfony\Component\Yaml\Yaml;`
`22`	`22`	`use TYPO3\CMS\Core\Utility\GeneralUtility;`
`23`	`23`
`24`		`-class DefaultsLoader`
	`24`	`+readonly class DefaultsLoader`
`25`	`25`	`{`
`26`	`26`	`/**`
`27`	`27`	`* @return array{`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`/**`
`28`	`28`	`* @internal Not part of TYPO3's public API.`
`29`	`29`	`*/`
`30`		`-class GridFactory`
	`30`	`+readonly class GridFactory`
`31`	`31`	`{`
`32`	`32`	`/**`
`33`	`33`	`* @param array<ContentBlockData> $records`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`/**`
`24`	`24`	`* @internal Not part of TYPO3's public API.`
`25`	`25`	`*/`
`26`		`-class HtmlTemplateCodeGenerator`
	`26`	`+readonly class HtmlTemplateCodeGenerator`
`27`	`27`	`{`
`28`	`28`	`public function generateEditorPreviewTemplate(LoadedContentBlock $contentBlockConfiguration): string`
`29`	`29`	`{`