Consider reading environment variables from console

Author: brotkrueml

config/settings.php

@@ -3,14 +3,21 @@
 declare(strict_types=1);
 
 use Dotenv\Exception\InvalidPathException;
+use FriendsOfTYPO3\CrowdinBase\Settings\EnvironmentVariables;
 use FriendsOfTYPO3\CrowdinBase\Settings\Settings;
 use FriendsOfTYPO3\CrowdinBase\Settings\PathResolver;
 
 try {
     $dotenv = Dotenv\Dotenv::createImmutable(getcwd());
     $dotenv->load();
 } catch (InvalidPathException) {
-    die("\n==> .env file not found! Please copy the .env.example in your project root folder to .env and set the configuration accordingly.\n\n");
+    // Environment variables can also be defined in console, so there is no .env file necessary
+}
+
+foreach (EnvironmentVariables::cases() as $variable) {
+    if (getenv($variable->name) !== false) {
+        $_ENV[$variable->name] = getenv($variable->name);
+    }
 }
 
 if (file_exists(__DIR__ . '/skippedProjects.php')) {

src/Settings/EnvironmentVariables.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace FriendsOfTYPO3\CrowdinBase\Settings;
+
+enum EnvironmentVariables
+{
+    case CONFIGURATION_FILE;
+    case CROWDIN_ACCESS_TOKEN;
+}

src/Settings/Settings.php

@@ -10,11 +10,6 @@
  */
 final readonly class Settings
 {
-    private const array REQUIRED_ENV_KEYS = [
-        'CONFIGURATION_FILE',
-        'CROWDIN_ACCESS_TOKEN',
-    ];
-
     /**
      * @param list<non-empty-string> $skippedProjects
      */
@@ -30,9 +25,9 @@ private function __construct(
      */
     public static function fromEnvironment(array $env, array $skippedProjects, PathResolver $pathResolver): self
     {
-        foreach (self::REQUIRED_ENV_KEYS as $key) {
-            if (!isset($env[$key])) {
-                throw UndefinedEnvironmentVariableException::fromEnvironmentKey($key);
+        foreach (EnvironmentVariables::cases() as $variable) {
+            if (!isset($env[$variable->name])) {
+                throw UndefinedEnvironmentVariableException::fromEnvironmentKey($variable->name);
             }
         }
 

src/Settings/UndefinedEnvironmentVariableException.php

@@ -10,7 +10,7 @@ public static function fromEnvironmentKey(string $key): self
     {
         return new self(
             \sprintf(
-                'The environment variable "%s" is not defined in the .env file. Have a look into the .env.example file for more details.',
+                'The environment variable "%s" is not defined as environment variable (either in .env file or as environment variable). Have a look into the .env.example file for more details.',
                 $key,
             ),
             1762853210

tests/Settings/UndefinedEnvironmentVariableExceptionTest.php

@@ -19,7 +19,7 @@ public function fromEnvironmentKey(): void
         $actual = UndefinedEnvironmentVariableException::fromEnvironmentKey('some-key');
 
         self::assertSame(
-            'The environment variable "some-key" is not defined in the .env file. Have a look into the .env.example file for more details.',
+            'The environment variable "some-key" is not defined as environment variable (either in .env file or as environment variable). Have a look into the .env.example file for more details.',
             $actual->getMessage(),
         );
         self::assertSame(1762853210, $actual->getCode());