Skip to content

Commit 5594787

Browse files
committed
Rename Project->name to Project->extensionKey
The property holds the extension key, so it should be named like that.
1 parent e25d86f commit 5594787

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/Configuration/ConfigurationWriter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public function write(array $projects): void
3838

3939
$projectsAsArray[$project->identifier] = [
4040
'id' => $project->id,
41-
'extensionKey' => $this->extensionKeyGenerator->generate($project->identifier, $project->name),
41+
'extensionKey' => $this->extensionKeyGenerator->generate($project->identifier, $project->extensionKey),
4242
'languages' => $project->languages,
4343
];
4444
}

src/Configuration/Entity/Project.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
/**
1313
* @param int $id The Crowdin ID, for example: 368353
1414
* @param string $identifier The Crowdin identifier, for example: "typo3-extension-news"
15-
* @param string $name The TYPO3 extension key, for example: "news"
15+
* @param string $extensionKey The TYPO3 extension key, for example: "news"
1616
* @param list<Language> $languages
1717
*/
1818
public function __construct(
1919
public int $id,
2020
public string $identifier,
21-
public string $name,
21+
public string $extensionKey,
2222
public array $languages,
2323
) {}
2424
}

tests/Configuration/ConfigurationReaderTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function readReturnsConfigurationCorrectly(): void
2626

2727
self::assertSame('typo3-extension-news', $actual[0]->identifier);
2828
self::assertSame(368353, $actual[0]->id);
29-
self::assertSame('news', $actual[0]->name);
29+
self::assertSame('news', $actual[0]->extensionKey);
3030
self::assertSame('km', $actual[0]->languages[0]->id);
3131
self::assertSame('Khmer', $actual[0]->languages[0]->name);
3232
self::assertSame('pt-BR', $actual[0]->languages[1]->id);
@@ -36,15 +36,15 @@ public function readReturnsConfigurationCorrectly(): void
3636

3737
self::assertSame('typo3-cms', $actual[1]->identifier);
3838
self::assertSame(368815, $actual[1]->id);
39-
self::assertSame('typo3-cms', $actual[1]->name);
39+
self::assertSame('typo3-cms', $actual[1]->extensionKey);
4040
self::assertSame('el', $actual[1]->languages[0]->id);
4141
self::assertSame('Greek', $actual[1]->languages[0]->name);
4242
self::assertSame('eo', $actual[1]->languages[1]->id);
4343
self::assertSame('Esperanto', $actual[1]->languages[1]->name);
4444

4545
self::assertSame('typo3-extension-ttaddress', $actual[2]->identifier);
4646
self::assertSame(369561, $actual[2]->id);
47-
self::assertSame('tt_address', $actual[2]->name);
47+
self::assertSame('tt_address', $actual[2]->extensionKey);
4848
self::assertSame('ro', $actual[2]->languages[0]->id);
4949
self::assertSame('Romanian', $actual[2]->languages[0]->name);
5050
self::assertSame('uk', $actual[2]->languages[1]->id);

0 commit comments

Comments
 (0)