[BUGFIX] fix #800, constructor DependencyInjection had a wrong mixture of two options: option 1. would be with declared variables and without visibility in the parameters, 2. is now without declared variables but declaration directly in the parameters, which includes the visibility 'private' and the 'readonly' option

Author: DavidBruchmann

Classes/Controller/BuilderModuleController.php

@@ -51,26 +51,16 @@ class BuilderModuleController extends ActionController
 {
 
     public function __construct(
-        FileGenerator $fileGenerator,
-        IconFactory $iconFactory,
-        PageRenderer $pageRenderer,
-        ExtensionInstallationStatus $extensionInstallationStatus,
-        ExtensionSchemaBuilder $extensionSchemaBuilder,
-        ExtensionService $extensionService,
-        ModuleTemplateFactory $moduleTemplateFactory,
-        ExtensionValidator $extensionValidator,
-        ExtensionRepository $extensionRepository,
-    )
-    {
-        $this->fileGenerator = $fileGenerator;
-        $this->iconFactory = $iconFactory;
-        $this->pageRenderer = $pageRenderer;
-        $this->extensionInstallationStatus = $extensionInstallationStatus;
-        $this->extensionSchemaBuilder = $extensionSchemaBuilder;
-        $this->extensionService = $extensionService;
-        $this->moduleTemplateFactory = $moduleTemplateFactory;
-        $this->extensionValidator = $extensionValidator;
-        $this->extensionRepository = $extensionRepository;
+        private readonly FileGenerator $fileGenerator,
+        private readonly IconFactory $iconFactory,
+        private readonly PageRenderer $pageRenderer,
+        private readonly ExtensionInstallationStatus $extensionInstallationStatus,
+        private readonly ExtensionSchemaBuilder $extensionSchemaBuilder,
+        private readonly ExtensionService $extensionService,
+        private readonly ModuleTemplateFactory $moduleTemplateFactory,
+        private readonly ExtensionValidator $extensionValidator,
+        private readonly ExtensionRepository $extensionRepository,
+    ){
     }
 
     private ExtensionBuilderConfigurationManager $extensionBuilderConfigurationManager;