[FEATURE] Add support for ext:rsaauth password submission

Author: ohader

Classes/Backend/ConfirmationController.php

@@ -102,29 +102,27 @@ protected function requestAction(ServerRequestInterface $request, ConfirmationBu
             if (!empty($bundle->getRequestMetaData()->getReturnUrl())) {
                 $view->assign('cancelUri', (string)$this->buildActionUriFromBundle('cancel', $bundle));
             }
+            $this->applyAdditionalJavaScriptModules();
             return new HtmlResponse($view->render());
         }
         // @todo Add JSON handling
         return new JsonResponse([], 500);
     }
 
     /**
-     * @todo ext:rsaauth not working yet in TYPO3 v9, extract to optional "controller enhancer"
+     * Load additional JavaScript modules/libraries (e.g. required for `ext:rsaauth` in TYPO3 v9)
      */
-    protected function applyRsaAuth()
+    protected function applyAdditionalJavaScriptModules(): void
     {
-        $isEnabled = ($GLOBALS['TYPO3_CONF_VARS']['BE']['loginSecurityLevel'] ?? '') === 'rsa';
-        if (!$isEnabled) {
-            return;
-        }
-        $rsaEncryptionEncoder = GeneralUtility::makeInstance(\TYPO3\CMS\Rsaauth\RsaEncryptionEncoder::class);
-        $rsaEncryptionEncoder->enableRsaEncryption(true);
-        // PageRender contains JavaScript libs and inline code...
+        (GeneralUtility::makeInstance(ExternalServiceAdapter::class))->emitLoginProviderSignal();
     }
 
     protected function verifyAction(ServerRequestInterface $request, ConfirmationBundle $bundle): ResponseInterface
     {
-        $confirmationPassword = (string)($request->getParsedBody()['confirmationPassword'] ?? '');
+        $parsedBody = $request->getParsedBody();
+        $confirmationPassword = empty($parsedBody['confirmationPasswordInternal'])
+            ? (string)($parsedBody['confirmationPassword'] ?? '') // default field
+            : $parsedBody['confirmationPasswordInternal']; // filled e.g. by `ext:rsaauth`
         $loggerContext = $this->createLoggerContext($bundle, $this->user);
 
         if (!$this->isJsonRequest($request)) {

Classes/Backend/ExternalServiceAdapter.php

@@ -0,0 +1,53 @@
+<?php
+declare(strict_types = 1);
+namespace FriendsOfTYPO3\SudoMode\Backend;
+
+/*
+ * This file is part of the TYPO3 CMS project.
+ *
+ * It is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License, either version 2
+ * of the License, or any later version.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ *
+ * The TYPO3 project - inspiring people to share!
+ */
+
+use TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider;
+use TYPO3\CMS\Core\Page\PageRenderer;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Extbase\Object\ObjectManager;
+use TYPO3\CMS\Extbase\Object\ObjectManagerInterface;
+use TYPO3\CMS\Extbase\SignalSlot\Dispatcher;
+
+/**
+ * Aims to adapt external services or extensions to be working with `ext:sudo_mode`.
+ */
+class ExternalServiceAdapter
+{
+    public function emitLoginProviderSignal(PageRenderer $pageRenderer = null): void
+    {
+        $this->getSignalSlotDispatcher()->dispatch(
+            UsernamePasswordLoginProvider::class,
+            UsernamePasswordLoginProvider::SIGNAL_getPageRenderer,
+            [$pageRenderer ?? $this->getPageRenderer()]
+        );
+    }
+
+    public function getSignalSlotDispatcher(): Dispatcher
+    {
+        return $this->getObjectManager()->get(Dispatcher::class);
+    }
+
+    public function getObjectManager(): ObjectManagerInterface
+    {
+        return GeneralUtility::makeInstance(ObjectManager::class);
+    }
+
+    public function getPageRenderer(): PageRenderer
+    {
+        return GeneralUtility::makeInstance(PageRenderer::class);
+    }
+}

README.md

@@ -5,7 +5,7 @@ TYPO3 extension providing "sudo mode" to mitigate unintended modifications.
 > :information_source: **beta** state - feel free to test and provide feedback for this package
 
 * TYPO3 v10 LTS
-* TYPO3 v9 LTS (`ext:rsaauth` not supported, yet)
+* TYPO3 v9 LTS (supports `ext:rsaauth` as well)
 
 ## Installation
 

Resources/Private/Templates/Backend/Request.html

@@ -29,7 +29,10 @@ <h4 class="modal-title">
                         <f:form id="confirm-sudo" class="form" method="post" actionUri="{verifyUri}">
                             <div class="form-group">
                                 <div class="form-control-holder">
-                                    <f:form.password name="confirmationPassword" class="form-control" placeholder="Password" />
+                                    <f:form.password name="confirmationPassword" class="form-control" placeholder="Password"
+                                                     additionalAttributes="{data-rsa-encryption: 'confirmationPasswordInternal'}" />
+                                    <!-- Internal password field, e.g. used for ext:rsaauth -->
+                                    <f:form.hidden name="confirmationPasswordInternal" id="confirmationPasswordInternal" />
                                 </div>
                             </div>
                         </f:form>

composer.json

@@ -17,6 +17,9 @@
     "issues": "https://github.com/FriendsOfTYPO3/sudo-mode/issues"
   },
   "require": {
+    "ext-dom": "*",
+    "ext-libxml": "*",
+    "ext-xml": "*",
     "typo3/cms-core": "^9.5 || 10.4.x@dev"
   },
   "autoload": {