Skip to content

Commit 5139b6a

Browse files
committed
Merged and updated to 3.2.1
2 parents d65b938 + 596ac51 commit 5139b6a

File tree

165 files changed

+692
-699
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

165 files changed

+692
-699
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Contributing to BlazorWebFormsComponents
22

3-
Thank you for taking the time to consider contributing to our project.
3+
Thank you for taking the time to consider contributing to our project.
44

55
The following is a set of guidelines for contributing to the project. These are mostly guidelines, not rules, and can be changed in the future. Please submit your suggestions with a pull-request to this document.
66

77
1. [Code of Conduct](#code-of-conduct)
88
1. [What should I know before I get started?](#what-should-i-know-before-i-get-started?)
9-
1. [Project Folder Structure](#project-folder-structure)
9+
1. [Project Folder Structure](#project-folder-structure)
1010
1. [Design Decisions](#design-decisions)
1111
1. [How can I contribute?](#how-can-i-contribute?)
1212
1. [Tell us your story](#tell-us-your-story)
@@ -28,7 +28,7 @@ This project is designed to be built and run primarily with Visual Studio 2019.
2828

2929
```
3030
/docs -- User Documentation
31-
/samples -- Usage Samples
31+
/samples -- Usage Samples
3232
BeforeWebForms
3333
AfterBlazorClientSide -- Shell project with WebAssembly config
3434
AfterBlazorServerSide -- Shared project with Server-Side config
@@ -49,7 +49,7 @@ All official versions of the project are built and delivered with Azure DevOps P
4949

5050
Design for this project is ultimately decided by the project lead, [Jeff Fritz](https://github.com/csharpfritz). The following project tenets are adhered to when making decisions:
5151

52-
1. All attributes of the original controls should be supported. This helps emphasize the 'convert your markup' feature.
52+
1. All attributes of the original controls should be supported. This helps emphasize the 'convert your markup' feature.
5353
1. HTML markup generated by the components should replicate the markup generated by the original controls. This helps to ensure the components behave as the Web Forms controls were expected to.
5454
1. Minimal .NET APIs should be supported, in order to present the API. The following are the primary APIs available:
5555
1. Component events: OnInit, OnLoad, OnPrerender, OnUnload
@@ -75,10 +75,10 @@ Tell us how you are currently using the web forms framework so that we can build
7575

7676
All code for a component should have an assigned issue that matches it. This way we can prevent contributors from working on the same feature at the same time.
7777

78-
Any code that is written to support a component are required to be accompanied with unit tests at the time the pull request is submitted. Pull requests without unit tests will be delayed and asked for unit tests to prove their functionality. We use the [Razor Components Testing Library](https://www.nuget.org/packages/Razor.Components.Testing.Library/) to test our components.
78+
Any code that is written to support a component are required to be accompanied with unit tests at the time the pull request is submitted. Pull requests without unit tests will be delayed and asked for unit tests to prove their functionality. We use the [bUnit](https://www.nuget.org/packages/bunit/) to test our components.
7979

8080
Code for components' features should also include some definition in the `/docs` folder so that our users can identify and understand which feature is supported.
8181

8282
### Write documentation
8383

84-
The documentation for the migration and consumption of these components will be significant in scope and need to cover many scenarios. We are always looking for help to add content to the `/docs` section of the repository with proper links back through to the main `/README.md`
84+
The documentation for the migration and consumption of these components will be significant in scope and need to cover many scenarios. We are always looking for help to add content to the `/docs` section of the repository with proper links back through to the main `/README.md`.

global.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
2-
"sdk": {
3-
"version": "3.1.201"
2+
"sdk": {
3+
"version": "3.1.300",
4+
"rollForward": "latestMinor"
45
}
56
}

src/BlazorWebFormsComponents.Test/AdRotator/Rotate.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
</Fixture>
88

99
@code {
10-
void RotateTest()
10+
void RotateTest(Fixture fixture)
1111
{
12-
var cut = GetComponentUnderTest();
12+
var cut = fixture.GetComponentUnderTest();
1313
var img = cut.Find("img");
1414
var alternatText = img.Attributes["alt"].Value;
1515

src/BlazorWebFormsComponents.Test/BaseWebFormsComponent/BubbleEvent.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
@code {
1212

1313

14-
void FirstTest() {
14+
void FirstTest(Fixture fixture) {
1515

16-
var cut = GetComponentUnderTest<TestBubbleComponent>();
16+
var cut = fixture.GetComponentUnderTest<TestBubbleComponent>();
1717
cut.Find("button").Click();
1818

1919
cut.Instance.EventRaised.Count().ShouldBe(1);
Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
@inherits TestComponentBase
22

3-
<Fixture
4-
Test="FirstTest"
5-
>
3+
<Fixture Test="FirstTest">
64
<ComponentUnderTest>
75
<ListView Items="Widget.SimpleWidgetList"
86
ItemType="Widget"
@@ -11,7 +9,7 @@
119
<LayoutTemplate Context="itemPlaceholder">
1210
<div>
1311
<b>Header <Button @ref="MyButton">My Button</Button></b>
14-
<br/>
12+
<br />
1513
@itemPlaceholder
1614
</div>
1715
</LayoutTemplate>
@@ -22,13 +20,14 @@
2220

2321
@code {
2422

25-
Button MyButton { get; set; }
23+
Button MyButton { get; set; }
2624

27-
void FirstTest() {
25+
void FirstTest(Fixture fixture)
26+
{
2827

29-
var cut = GetComponentUnderTest<ListView<Widget>>();
30-
cut.Instance.Controls.Count().ShouldBe(1);
28+
var cut = fixture.GetComponentUnderTest<ListView<Widget>>();
29+
cut.Instance.Controls.Count().ShouldBe(1);
3130

32-
}
31+
}
3332

3433
}

src/BlazorWebFormsComponents.Test/BaseWebFormsComponent/Parent.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424

2525
Button MyButton { get; set; }
2626

27-
void FirstTest() {
27+
void FirstTest(Fixture fixture) {
2828

29-
var cut = GetComponentUnderTest();
29+
var cut = fixture.GetComponentUnderTest();
3030
cut.FindAll("button").Count().ShouldNotBe(0);
3131

3232
MyButton.ShouldNotBeNull();

src/BlazorWebFormsComponents.Test/BlazorWebFormsComponents.Test.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88

99
<ItemGroup>
10-
<PackageReference Include="bunit" Version="1.0.0-beta-6" />
10+
<PackageReference Include="bunit" Version="1.0.0-beta-7" />
1111
<PackageReference Include="Microsoft.AspNetCore.Components" Version="3.1.1" />
1212
<PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="3.1.1" />
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
14-
<PackageReference Include="Moq" Version="4.13.1" />
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.*" />
14+
<PackageReference Include="Moq" Version="4.14.1" />
1515
<PackageReference Include="Shouldly" Version="3.0.2" />
1616
<PackageReference Include="xunit.core" Version="2.4.1" />
1717
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">

src/BlazorWebFormsComponents.Test/Button/Click.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919

2020
}
2121

22-
void FirstTest()
22+
void FirstTest(Fixture fixture)
2323
{
2424
// Given
25-
var cut = GetComponentUnderTest();
25+
var cut = fixture.GetComponentUnderTest();
2626

2727
TheContent.ShouldBe("Not clicked yet!");
2828

src/BlazorWebFormsComponents.Test/Button/Command.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020

2121
}
2222

23-
void FirstTest()
23+
void FirstTest(Fixture fixture)
2424
{
2525
// Given
26-
var cut = GetComponentUnderTest();
26+
var cut = fixture.GetComponentUnderTest();
2727

2828
TheContent.ShouldBe("No Command yet!");
2929

src/BlazorWebFormsComponents.Test/DataBinder/Eval_SimpleDataList.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717

1818
@code {
1919

20-
void FirstTest()
20+
void FirstTest(Fixture fixture)
2121
{
2222

23-
var cut = GetComponentUnderTest();
23+
var cut = fixture.GetComponentUnderTest();
2424

2525
cut.FindAll("span").Count().ShouldBe(5);
2626
cut.FindAll("span").Skip(1).First().TextContent.ShouldBe("My Widget List");

0 commit comments

Comments
 (0)