fix: failing tests

Author: FrogDevelopper

src/test/java/com/frogdevelopment/jwt/JwtProcessTokenFilterTest.java

@@ -66,6 +66,7 @@ void shouldClearSecurityContextWhenAuthenticationIsNull() throws IOException, Se
     @Test
     void shouldClearSecurityContextWhenJwtExceptionIsRaised() throws ServletException, IOException {
         // given
+        given(request.getRequestURL()).willReturn(new StringBuffer("http://local_test/my_uri"));
         givenAnExceptionWhenResolvingToken();
 
         // when

src/test/java/com/frogdevelopment/jwt/ResolveTokenToAuthenticationTest.java

@@ -1,81 +1,83 @@
 package com.frogdevelopment.jwt;
 
 import static com.frogdevelopment.jwt.JwtAuthenticationToken.AUTHORITIES_KEY;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.*;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.BDDMockito.given;
+import static org.mockito.BDDMockito.then;
 
 import io.jsonwebtoken.Jwts;
 import io.jsonwebtoken.SignatureAlgorithm;
+import io.jsonwebtoken.impl.DefaultClaims;
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
+import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 import org.springframework.mock.web.MockHttpServletRequest;
-import org.springframework.security.core.authority.SimpleGrantedAuthority;
 
 @Tag("unitTest")
 @ExtendWith(MockitoExtension.class)
 class ResolveTokenToAuthenticationTest {
 
     private static final String USERNAME = "USERNAME";
     private static final byte[] SIGNING_KEY = "my-signing-key".getBytes();
+    private static final List<String> ROLES = List.of("ADMIN", "USER");
 
     @InjectMocks
     private ResolveTokenToAuthentication resolveTokenToAuthentication;
     @Mock
-    private ResolveClaimsFromToken resolveClaimsFromToken;
-    @Mock
     private RetrieveTokenFromRequest retrieveTokenFromRequest;
-    private static final List<String> ROLES = List.of("ADMIN", "USER");
+    @Mock
+    private TokenToAuthentication tokenToAuthentication;
 
     @Test
-    void createAuthentication_should_return_authentication() {
+    void should_return_null_when_no_token() {
         // given
-        MockHttpServletRequest request = givenRequest();
-        givenClaims();
+        var request = new MockHttpServletRequest();
+        givenNotToken(request);
 
         // when
         var authentication = resolveTokenToAuthentication.call(request);
 
         // then
-        assertNotNull(authentication);
-        assertEquals(USERNAME, authentication.getPrincipal());
-        assertEquals(USERNAME, authentication.getName());
-        assertNotNull(authentication.getDetails());
-        assertTrue(authentication.isAuthenticated());
-        assertNull(authentication.getCredentials());
-        var authorities = ROLES.stream().map(SimpleGrantedAuthority::new).collect(Collectors.toList());
-        assertEquals(authentication.getAuthorities(), authorities);
+        assertThat(authentication).isNull();
+        then(tokenToAuthentication).shouldHaveNoInteractions();
     }
 
-    private MockHttpServletRequest givenRequest() {
-        MockHttpServletRequest request = new MockHttpServletRequest();
-        given(retrieveTokenFromRequest.call(request)).willReturn(givenToken());
-        return request;
-    }
+    @Test
+    void should_return_authentication_from_token() {
+        // given
+        var request = new MockHttpServletRequest();
+        givenToken(request);
+        givenJwtAuthenticationToken();
 
-    private void givenClaims() {
-        given(resolveClaimsFromToken.call(anyString())).willAnswer(i -> Jwts.parser()
-                .setSigningKey(SIGNING_KEY)
-                .parseClaimsJws(i.getArgument(0))
-                .getBody());
+        // when
+        var authentication = resolveTokenToAuthentication.call(request);
+
+        // then
+        assertThat(authentication).isNotNull();
     }
 
-    private String givenToken() {
-        return Jwts.builder()
+    private void givenToken(MockHttpServletRequest request) {
+        given(retrieveTokenFromRequest.call(request)).willReturn(Jwts.builder()
                 .setSubject(USERNAME)
                 .addClaims(Map.of(AUTHORITIES_KEY, ROLES))
                 .signWith(SignatureAlgorithm.HS512, SIGNING_KEY)
-                .compact();
+                .compact());
+    }
+
+    private void givenNotToken(MockHttpServletRequest request) {
+        given(retrieveTokenFromRequest.call(request)).willReturn(null);
+    }
+
+    private void givenJwtAuthenticationToken() {
+        given(tokenToAuthentication.call(anyString()))
+                .willAnswer(i -> new JwtAuthenticationToken(new DefaultClaims(), "token"));
     }
 
 }

src/test/java/com/frogdevelopment/jwt/TokenToAuthenticationTest.java

@@ -0,0 +1,72 @@
+package com.frogdevelopment.jwt;
+
+import static com.frogdevelopment.jwt.JwtAuthenticationToken.AUTHORITIES_KEY;
+import static io.jsonwebtoken.SignatureAlgorithm.HS512;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.BDDMockito.given;
+
+import io.jsonwebtoken.Jwts;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.security.core.authority.SimpleGrantedAuthority;
+
+@Tag("unitTest")
+@ExtendWith(MockitoExtension.class)
+class TokenToAuthenticationTest {
+
+    private static final String USERNAME = "USERNAME";
+    private static final byte[] SIGNING_KEY = "my-signing-key".getBytes();
+    private static final List<String> ROLES = List.of("ADMIN", "USER");
+
+    @InjectMocks
+    private TokenToAuthentication tokenToAuthentication;
+    @Mock
+    private ResolveClaimsFromToken resolveClaimsFromToken;
+
+    @Test
+    void createAuthentication_should_return_authentication() {
+        // given
+        var token = givenToken();
+        givenClaims();
+
+        // when
+        var authentication = tokenToAuthentication.call(token);
+
+        // then
+        assertNotNull(authentication);
+        assertEquals(USERNAME, authentication.getPrincipal());
+        assertEquals(USERNAME, authentication.getName());
+        assertNotNull(authentication.getDetails());
+        assertTrue(authentication.isAuthenticated());
+        assertNull(authentication.getCredentials());
+        var authorities = ROLES.stream().map(SimpleGrantedAuthority::new).collect(Collectors.toList());
+        assertEquals(authentication.getAuthorities(), authorities);
+    }
+
+    private String givenToken() {
+        return Jwts.builder()
+                .setSubject(USERNAME)
+                .addClaims(Map.of(AUTHORITIES_KEY, ROLES))
+                .signWith(HS512, SIGNING_KEY)
+                .compact();
+    }
+
+    private void givenClaims() {
+        given(resolveClaimsFromToken.call(anyString())).willAnswer(i -> Jwts.parser()
+                .setSigningKey(SIGNING_KEY)
+                .parseClaimsJws(i.getArgument(0))
+                .getBody());
+    }
+
+}

src/test/java/com/frogdevelopment/jwt/app/conf/AuthenticationConfiguration.java

@@ -8,7 +8,4 @@
 @EnableWebSecurity
 public class AuthenticationConfiguration extends JwtAuthorizationConfigurerAdapter {
 
-    public AuthenticationConfiguration() {
-        super(jwtProcessTokenFilter);
-    }
 }