feat: validate promocode/campaign relation on update

Author: leoslopez

Doppler.HtmlEditorApi/Controllers/CampaignsController.cs

@@ -229,7 +229,12 @@ public async Task<IActionResult> UpdatePromoCode(string accountName, int campaig
                 Categories: promoCode.categories,
                 CampaignId: campaignId);
 
-            await _promoCodeRepository.UpdatePromoCode(promoCodeModel);
+            var updateResult = await _promoCodeRepository.UpdatePromoCode(promoCodeModel);
+
+            if (!updateResult)
+            {
+                return new NotFoundObjectResult("The Campaign/PromoCode relation doesn't exist.");
+            }
 
             return new OkObjectResult($"Promo code {promoCodeId} was successfully updated.");
         }

Doppler.HtmlEditorApi/Repositories.DopplerDb/DopplerPromoCodeRepository.cs

@@ -32,10 +32,11 @@ public async Task<int> CreatePromoCode(PromoCodeModel promoCodeModel)
         return result.IdDynamicContentPromoCode;
     }
 
-    public async Task UpdatePromoCode(PromoCodeModel promoCodeModel)
+    public async Task<bool> UpdatePromoCode(PromoCodeModel promoCodeModel)
     {
         var updatePromoCodeDbQuery = new UpdatePromoCodeDbQuery(
             Id: promoCodeModel.Id,
+            IdCampaign: promoCodeModel.CampaignId,
             Type: promoCodeModel.Type,
             Value: promoCodeModel.Value,
             IncludeShipping: promoCodeModel.IncludeShipping,
@@ -46,7 +47,8 @@ public async Task UpdatePromoCode(PromoCodeModel promoCodeModel)
             MaxUses: promoCodeModel.MaxUses,
             Categories: promoCodeModel.Categories);
 
-        await _dbContext.ExecuteAsync(updatePromoCodeDbQuery);
+        var result = await _dbContext.ExecuteAsync(updatePromoCodeDbQuery);
+        return result > 0;
     }
 }
 

Doppler.HtmlEditorApi/Repositories.DopplerDb/Queries/UpdatePromoCodeDbQuery.cs

@@ -4,6 +4,7 @@ namespace Doppler.HtmlEditorApi.Repositories.DopplerDb.Queries;
 
 public record UpdatePromoCodeDbQuery(
     int Id,
+    int IdCampaign,
     string Type,
     decimal Value,
     bool IncludeShipping,
@@ -26,5 +27,5 @@ UPDATE DynamicContentPromoCode
     ExpireDays = @ExpireDays,
     MaxUses = @MaxUses,
     Categories = @Categories
-WHERE IdDynamicContentPromoCode = @Id";
+WHERE IdDynamicContentPromoCode = @Id AND IdCampaign = @IdCampaign";
 }

Doppler.HtmlEditorApi/Repositories/IPromoCodeRepository.cs

@@ -6,6 +6,6 @@ namespace Doppler.HtmlEditorApi.Repositories;
 public interface IPromoCodeRepository
 {
     Task<int> CreatePromoCode(PromoCodeModel promoCodeModel);
-    Task UpdatePromoCode(PromoCodeModel promoCodeModel);
+    Task<bool> UpdatePromoCode(PromoCodeModel promoCodeModel);
 }