Skip to content

Commit 723d307

Browse files
Merge pull request #190 from FromDoppler/DE-971-new-jenkins-compatibility
build: minor adjustments
2 parents cd19361 + 8ef91cf commit 723d307

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

HelloMicroservice.sln

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Misc Files", "Misc Files",
1717
build-n-publish.sh = build-n-publish.sh
1818
demo.http = demo.http
1919
Dockerfile = Dockerfile
20-
Jenkinsfile = Jenkinsfile
20+
doppler-jenkins-ci.groovy = doppler-jenkins-ci.groovy
2121
package.json = package.json
2222
README.md = README.md
2323
verify-w-docker.sh = verify-w-docker.sh

README.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ For the moment, it is only a kind of example. In the future, it could be convert
88

99
We base our CI/CD process on Jenkins, Docker Hub, and Docker Swarm.
1010

11-
Jenkins generates the images based on [doppler-jenkins-ci.groovy](./doppler-jenkins-ci.groovy) (a symlink to [Jenkisfile](./Jenkinsfile)). We refer to these generated images in a Docker Swarm using an _auto-redeploy_ approach. The [Doppler Swarm repository](https://github.com/MakingSense/doppler-swarm) stores the configuration of our Docker Swarm.
11+
Jenkins generates the images based on [doppler-jenkins-ci.groovy](./doppler-jenkins-ci.groovy) (a renamed Jenkisfile). We refer to these generated images in a Docker Swarm using an _auto-redeploy_ approach. The [Doppler Swarm repository](https://github.com/MakingSense/doppler-swarm) stores the configuration of our Docker Swarm.
1212

1313
You can find a detailed description of our Git flow and the relation with Docker Hub in [Doppler-Forms repository](https://github.com/MakingSense/doppler-forms/blob/master/README.md#continuous-deployment-to-test-and-production-environments), but basically, it is the following:
1414

@@ -22,7 +22,7 @@ You can find a detailed description of our Git flow and the relation with Docker
2222

2323
## Run validations in local environment
2424

25-
The source of truth related to the build process is [doppler-jenkins-ci.groovy](./doppler-jenkins-ci.groovy) (a symlink to [Jenkisfile](./Jenkinsfile)). It basically runs docker build, so, you can reproduce jenkins' build process running `docker build .` or `sh ./verify-w-docker.sh`.
25+
The source of truth related to the build process is [doppler-jenkins-ci.groovy](./doppler-jenkins-ci.groovy) (a renamed Jenkisfile). It basically runs docker build, so, you can reproduce jenkins' build process running `docker build .` or `sh ./verify-w-docker.sh`.
2626

2727
If you prefer to run these commands without docker, you can read [Dockerfile](./Dockerfile) and follow the steps manually.
2828

@@ -84,13 +84,6 @@ A simple way of doing that is copy all the files and then:
8484

8585
We have `{FC79D827-86F3-4F93-8064-C4927957A1D2}` for the main project, `{646F92A1-8B19-43E0-BED1-8A56B6FB9352}` for the test project, `{9BE75F53-F47E-4B35-9560-AA039EBC5B1C}` for the solution files and `{A6DDDBE4-738F-4679-809B-D7786BD5E7E5}` for the solution itself. It is possible generate new IDs using any tool, for example [Online GUID / UUID Generator](https://www.guidgenerator.com/)
8686

87-
- Ensure that the file `doppler-jenkins-ci.groovy` is a _symbolic link_ to `Jenkinsfile`
88-
89-
**IMPORTANT:** If you do not know what a symlink is, ask.
90-
91-
- In Linux or Mac: `ln -s Jenkinsfile doppler-jenkins-ci.groovy`
92-
- In Windows (with git bash as administrator): `export MSYS=winsymlinks:nativestrict; ln -s Jenkinsfile doppler-jenkins-ci.groovy`
93-
9487
### Push to GitHub
9588

9689
We are using the GitHub organizations [FromDoppler](https://github.com/FromDoppler) (for public code) and [MakingSense](https://github.com/MakingSense) (for private code).

gitlint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22

33
# It is only here for reference and backward compatibility, the source of truth
4-
# is Jenkinsfile
4+
# is doppler-jenkins-ci.groovy
55

66
# Stop script on NZEC
77
set -e

verify-w-docker.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22

33
# It is only here for reference and backward compatibility, the source of truth
4-
# is Jenkinsfile
4+
# is doppler-jenkins-ci.groovy
55

66
# Stop script on NZEC
77
set -e

0 commit comments

Comments
 (0)