Skip to content

Commit 151adbf

Browse files
fulopdanielpeter-tudosaragi96github-actions[bot]findmind
authored
Merge main to dev (#1359)
* fix(Toolbar): add missing padding option for the flyout (#1338) * fix(Toolbar): add missing padding option for the flyout Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com> * chore: add changeset Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com> * Update .changeset/dirty-pans-eat.md --------- Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com> Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> * chore: release packages (#1339) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: bump fondue to latest 12 (#1340) * chore: bump fondue to latest 12 * fix test --------- Co-authored-by: fulopdaniel <daniel.fulop@frontify.com> * chore: release packages (#1341) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(FlyoutToolbarButton): add missing body (#1342) * chore: release packages (#1343) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor(LinkSelector): improve blur handling (#1344) * refactor(LinkSelector): improve blur handling * add changeset * chore: release packages (#1345) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Cleanup template properties [CU-869b5g3w9] (#1346) * Removed `sector`, `unit` and `token` * Added changeset * chore: release packages (#1347) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com> Co-authored-by: Peter Razvan Tudosa <4538108+peter-tudosa@users.noreply.github.com> Co-authored-by: Rafael Giezendanner <rafael.giezendanner@frontify.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Fabian Keller <chaelli91@gmail.com>
1 parent ad2bde1 commit 151adbf

File tree

11 files changed

+50
-25
lines changed

11 files changed

+50
-25
lines changed

packages/app-bridge/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@
7777

7878
- chore: merge main to dev
7979

80+
## 3.12.0
81+
82+
### Minor Changes
83+
84+
- [#1346](https://github.com/Frontify/brand-sdk/pull/1346) [`47eaab2`](https://github.com/Frontify/brand-sdk/commit/47eaab210961db1eeb01cb3da2ff7d623a5b07a2) Thanks [@findmind](https://github.com/findmind)! - refactor(TemplateApiLegacy): removed unused `token`, `unit` and `sector`
85+
8086
## 3.11.2
8187

8288
### Patch Changes

packages/app-bridge/src/tests/TemplateApiLegacyDummy.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ export class TemplateApiLegacyDummy {
1818
project_type: 'A project type',
1919
published: 1,
2020
screen_id: 1,
21-
sector: 'A sector',
22-
token: '--token--',
23-
unit: 'px',
2421
width: 640,
2522
};
2623
}

packages/app-bridge/src/types/TemplateLegacy.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ export type TemplateApiLegacy = {
1414
project_type: string;
1515
published: number;
1616
screen_id: number;
17-
sector: string;
18-
token: string;
19-
unit: string;
2017
width: number;
2118
};
2219

packages/guideline-blocks-settings/CHANGELOG.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,30 @@
3232

3333
- [#1286](https://github.com/Frontify/brand-sdk/pull/1286) [`8ed6d57`](https://github.com/Frontify/brand-sdk/commit/8ed6d57ad71cf81d73798e4f639103960be8dc93) Thanks [@fulopdaniel](https://github.com/fulopdaniel)! - chore: bump fondue to v13
3434

35+
## 1.0.12
36+
37+
### Patch Changes
38+
39+
- [#1344](https://github.com/Frontify/brand-sdk/pull/1344) [`24bf5f2`](https://github.com/Frontify/brand-sdk/commit/24bf5f273f17cd8f0c03f1fd9f6194f10379f751) Thanks [@fulopdaniel](https://github.com/fulopdaniel)! - refactor(LinkSelector): improve blur handling
40+
41+
## 1.0.11
42+
43+
### Patch Changes
44+
45+
- [#1342](https://github.com/Frontify/brand-sdk/pull/1342) [`4268d60`](https://github.com/Frontify/brand-sdk/commit/4268d6019b039a08af099107cb0f547b26223598) Thanks [@ragi96](https://github.com/ragi96)! - fix(FlyoutToolbarButton): add missing body
46+
47+
## 1.0.10
48+
49+
### Patch Changes
50+
51+
- [#1340](https://github.com/Frontify/brand-sdk/pull/1340) [`167faba`](https://github.com/Frontify/brand-sdk/commit/167fabaab9e340cb3027531e906373b4c4de3039) Thanks [@ragi96](https://github.com/ragi96)! - chore: bump `@frontify/fondue` to latest `12.4.3`
52+
53+
## 1.0.9
54+
55+
### Patch Changes
56+
57+
- [#1338](https://github.com/Frontify/brand-sdk/pull/1338) [`a1e43c2`](https://github.com/Frontify/brand-sdk/commit/a1e43c2a4d6ed998dc202a4d9518f7bc7f8a4a8b) Thanks [@peter-tudosa](https://github.com/peter-tudosa)! - fix(FlyoutToolbarButton): add missing padding option
58+
3559
## 1.0.8
3660

3761
### Patch Changes

packages/guideline-blocks-settings/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Provides the block settings types for the guideline-blocks.
77
```ts
88
/* (c) Copyright Frontify Ltd., all rights reserved. */
99

10-
import { IconEnum, defineSettings } from '@frontify/guideline-blocks-settings';
10+
import { defineSettings } from '@frontify/guideline-blocks-settings';
1111

1212
export const settings = defineSettings({
1313
main: [
@@ -19,12 +19,12 @@ export const settings = defineSettings({
1919
choices: [
2020
{
2121
value: 'noline',
22-
icon: IconEnum.LineSpacer,
22+
icon: 'LineSpacer',
2323
label: 'Spacer (no line)',
2424
},
2525
{
2626
value: 'solid',
27-
icon: IconEnum.LineSolid,
27+
icon: 'LineSolid',
2828
label: 'Line',
2929
},
3030
],
@@ -43,9 +43,9 @@ export const settings = defineSettings({
4343

4444
## Code Structure
4545

46-
- `components` (React components which are reused across multiple blocks)
47-
- `utilities` (functionality without business logic)
48-
- `helpers` (functionality with business logic)
46+
- `components` (React components which are reused across multiple blocks)
47+
- `utilities` (functionality without business logic)
48+
- `helpers` (functionality with business logic)
4949

5050
## Using components
5151

packages/guideline-blocks-settings/src/components/BlockItemWrapper/Toolbar/FlyoutToolbarButton/FlyoutToolbarButton.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ export const FlyoutToolbarButton = ({
4444
{icon}
4545
</BaseToolbarButton>
4646
</Flyout.Trigger>
47-
<Flyout.Content side="bottom" align="end">
47+
<Flyout.Content side="bottom" align="end" padding="comfortable">
4848
{flyoutHeader ? <Flyout.Header>{flyoutHeader}</Flyout.Header> : null}
49-
{content}
49+
<Flyout.Body>{content}</Flyout.Body>
5050
{flyoutFooter ? <Flyout.Footer>{flyoutFooter}</Flyout.Footer> : null}
5151
</Flyout.Content>
5252
</Flyout.Root>

packages/guideline-blocks-settings/src/components/Link/LinkInput.spec.ct.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { withAppBridgeBlockStubs } from '@frontify/app-bridge';
55
import { LinkInput } from './LinkInput';
66

77
const LINK_INPUT_ID = '[data-test-id="link-input"]';
8-
const TEXT_INPUT_ID = '[data-test-id="text-input"] input';
8+
const TEXT_INPUT_ID = '[data-test-id="text-input"] input';
99
const INPUT_LABEL_CONTAINER_ID = '[data-test-id="input-label-container"]';
1010
const BUTTON_ID = '[data-test-id="fondue-dialog-trigger"]';
1111
const CHECKBOX_ID = '[data-test-id="fondue-checkbox"]';

packages/guideline-blocks-settings/src/components/Link/LinkInput.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export const LinkInput = ({
7676

7777
<div className="tw-mt-3 tw-flex tw-items-center tw-gap-1.5">
7878
<Checkbox id="new-tab" value={newTab} onChange={() => onToggleTab?.(!newTab)} />
79-
<Label id="new-tab-label" htmlFor="new-tab">
79+
<Label id="new-tab-label" htmlFor="new-tab" className="tw-whitespace-nowrap">
8080
Open in new tab
8181
</Label>
8282
</div>

packages/guideline-blocks-settings/src/components/Link/LinkSelector/LinkSelector.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,14 @@ export const LinkSelector = ({
5959
return (
6060
// eslint-disable-next-line jsx-a11y-x/no-static-element-interactions
6161
<div
62-
onPointerDown={(event) => event.preventDefault()}
62+
onPointerDownCapture={(event) => {
63+
event.stopPropagation();
64+
event.preventDefault();
65+
}}
66+
onFocusCapture={(event) => {
67+
event.stopPropagation();
68+
event.preventDefault();
69+
}}
6370
data-test-id="internal-link-selector"
6471
onKeyDown={onPressEnter}
6572
>

packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonEdit.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,7 @@ export const useFloatingButtonEdit = (
106106
useFloatingButtonEscape();
107107

108108
return {
109-
style: {
110-
...style,
111-
zIndex: 1000,
112-
},
109+
style,
113110
ref: useComposedRef<HTMLElement | null>(floating),
114111
};
115112
};

0 commit comments

Comments
 (0)