diff --git a/packages/app-bridge/CHANGELOG.md b/packages/app-bridge/CHANGELOG.md index 998074ff7..6a6af06b6 100644 --- a/packages/app-bridge/CHANGELOG.md +++ b/packages/app-bridge/CHANGELOG.md @@ -77,6 +77,12 @@ - chore: merge main to dev +## 3.12.0 + +### Minor Changes + +- [#1346](https://github.com/Frontify/brand-sdk/pull/1346) [`47eaab2`](https://github.com/Frontify/brand-sdk/commit/47eaab210961db1eeb01cb3da2ff7d623a5b07a2) Thanks [@findmind](https://github.com/findmind)! - refactor(TemplateApiLegacy): removed unused `token`, `unit` and `sector` + ## 3.11.2 ### Patch Changes diff --git a/packages/app-bridge/src/tests/TemplateApiLegacyDummy.ts b/packages/app-bridge/src/tests/TemplateApiLegacyDummy.ts index 3934765e4..061785561 100644 --- a/packages/app-bridge/src/tests/TemplateApiLegacyDummy.ts +++ b/packages/app-bridge/src/tests/TemplateApiLegacyDummy.ts @@ -18,9 +18,6 @@ export class TemplateApiLegacyDummy { project_type: 'A project type', published: 1, screen_id: 1, - sector: 'A sector', - token: '--token--', - unit: 'px', width: 640, }; } diff --git a/packages/app-bridge/src/types/TemplateLegacy.ts b/packages/app-bridge/src/types/TemplateLegacy.ts index fad2c5b2a..9dac393f3 100644 --- a/packages/app-bridge/src/types/TemplateLegacy.ts +++ b/packages/app-bridge/src/types/TemplateLegacy.ts @@ -14,9 +14,6 @@ export type TemplateApiLegacy = { project_type: string; published: number; screen_id: number; - sector: string; - token: string; - unit: string; width: number; }; diff --git a/packages/guideline-blocks-settings/CHANGELOG.md b/packages/guideline-blocks-settings/CHANGELOG.md index 26b03350b..d460ad144 100644 --- a/packages/guideline-blocks-settings/CHANGELOG.md +++ b/packages/guideline-blocks-settings/CHANGELOG.md @@ -32,6 +32,30 @@ - [#1286](https://github.com/Frontify/brand-sdk/pull/1286) [`8ed6d57`](https://github.com/Frontify/brand-sdk/commit/8ed6d57ad71cf81d73798e4f639103960be8dc93) Thanks [@fulopdaniel](https://github.com/fulopdaniel)! - chore: bump fondue to v13 +## 1.0.12 + +### Patch Changes + +- [#1344](https://github.com/Frontify/brand-sdk/pull/1344) [`24bf5f2`](https://github.com/Frontify/brand-sdk/commit/24bf5f273f17cd8f0c03f1fd9f6194f10379f751) Thanks [@fulopdaniel](https://github.com/fulopdaniel)! - refactor(LinkSelector): improve blur handling + +## 1.0.11 + +### Patch Changes + +- [#1342](https://github.com/Frontify/brand-sdk/pull/1342) [`4268d60`](https://github.com/Frontify/brand-sdk/commit/4268d6019b039a08af099107cb0f547b26223598) Thanks [@ragi96](https://github.com/ragi96)! - fix(FlyoutToolbarButton): add missing body + +## 1.0.10 + +### Patch Changes + +- [#1340](https://github.com/Frontify/brand-sdk/pull/1340) [`167faba`](https://github.com/Frontify/brand-sdk/commit/167fabaab9e340cb3027531e906373b4c4de3039) Thanks [@ragi96](https://github.com/ragi96)! - chore: bump `@frontify/fondue` to latest `12.4.3` + +## 1.0.9 + +### Patch Changes + +- [#1338](https://github.com/Frontify/brand-sdk/pull/1338) [`a1e43c2`](https://github.com/Frontify/brand-sdk/commit/a1e43c2a4d6ed998dc202a4d9518f7bc7f8a4a8b) Thanks [@peter-tudosa](https://github.com/peter-tudosa)! - fix(FlyoutToolbarButton): add missing padding option + ## 1.0.8 ### Patch Changes diff --git a/packages/guideline-blocks-settings/README.md b/packages/guideline-blocks-settings/README.md index d1067df17..cc4f52799 100644 --- a/packages/guideline-blocks-settings/README.md +++ b/packages/guideline-blocks-settings/README.md @@ -7,7 +7,7 @@ Provides the block settings types for the guideline-blocks. ```ts /* (c) Copyright Frontify Ltd., all rights reserved. */ -import { IconEnum, defineSettings } from '@frontify/guideline-blocks-settings'; +import { defineSettings } from '@frontify/guideline-blocks-settings'; export const settings = defineSettings({ main: [ @@ -19,12 +19,12 @@ export const settings = defineSettings({ choices: [ { value: 'noline', - icon: IconEnum.LineSpacer, + icon: 'LineSpacer', label: 'Spacer (no line)', }, { value: 'solid', - icon: IconEnum.LineSolid, + icon: 'LineSolid', label: 'Line', }, ], @@ -43,9 +43,9 @@ export const settings = defineSettings({ ## Code Structure -- `components` (React components which are reused across multiple blocks) -- `utilities` (functionality without business logic) -- `helpers` (functionality with business logic) +- `components` (React components which are reused across multiple blocks) +- `utilities` (functionality without business logic) +- `helpers` (functionality with business logic) ## Using components diff --git a/packages/guideline-blocks-settings/src/components/BlockItemWrapper/Toolbar/FlyoutToolbarButton/FlyoutToolbarButton.tsx b/packages/guideline-blocks-settings/src/components/BlockItemWrapper/Toolbar/FlyoutToolbarButton/FlyoutToolbarButton.tsx index 920c7abd2..eb07a3830 100644 --- a/packages/guideline-blocks-settings/src/components/BlockItemWrapper/Toolbar/FlyoutToolbarButton/FlyoutToolbarButton.tsx +++ b/packages/guideline-blocks-settings/src/components/BlockItemWrapper/Toolbar/FlyoutToolbarButton/FlyoutToolbarButton.tsx @@ -44,9 +44,9 @@ export const FlyoutToolbarButton = ({ {icon} - + {flyoutHeader ? {flyoutHeader} : null} - {content} + {content} {flyoutFooter ? {flyoutFooter} : null} diff --git a/packages/guideline-blocks-settings/src/components/Link/LinkInput.spec.ct.tsx b/packages/guideline-blocks-settings/src/components/Link/LinkInput.spec.ct.tsx index 46152cfaa..f836e35a3 100644 --- a/packages/guideline-blocks-settings/src/components/Link/LinkInput.spec.ct.tsx +++ b/packages/guideline-blocks-settings/src/components/Link/LinkInput.spec.ct.tsx @@ -5,7 +5,7 @@ import { withAppBridgeBlockStubs } from '@frontify/app-bridge'; import { LinkInput } from './LinkInput'; const LINK_INPUT_ID = '[data-test-id="link-input"]'; -const TEXT_INPUT_ID = '[data-test-id="text-input"] input'; +const TEXT_INPUT_ID = '[data-test-id="text-input"] input'; const INPUT_LABEL_CONTAINER_ID = '[data-test-id="input-label-container"]'; const BUTTON_ID = '[data-test-id="fondue-dialog-trigger"]'; const CHECKBOX_ID = '[data-test-id="fondue-checkbox"]'; diff --git a/packages/guideline-blocks-settings/src/components/Link/LinkInput.tsx b/packages/guideline-blocks-settings/src/components/Link/LinkInput.tsx index 3b8668f95..eb258856b 100644 --- a/packages/guideline-blocks-settings/src/components/Link/LinkInput.tsx +++ b/packages/guideline-blocks-settings/src/components/Link/LinkInput.tsx @@ -76,7 +76,7 @@ export const LinkInput = ({
onToggleTab?.(!newTab)} /> -
diff --git a/packages/guideline-blocks-settings/src/components/Link/LinkSelector/LinkSelector.tsx b/packages/guideline-blocks-settings/src/components/Link/LinkSelector/LinkSelector.tsx index 3a545375f..1ca27f76c 100644 --- a/packages/guideline-blocks-settings/src/components/Link/LinkSelector/LinkSelector.tsx +++ b/packages/guideline-blocks-settings/src/components/Link/LinkSelector/LinkSelector.tsx @@ -59,7 +59,14 @@ export const LinkSelector = ({ return ( // eslint-disable-next-line jsx-a11y-x/no-static-element-interactions
event.preventDefault()} + onPointerDownCapture={(event) => { + event.stopPropagation(); + event.preventDefault(); + }} + onFocusCapture={(event) => { + event.stopPropagation(); + event.preventDefault(); + }} data-test-id="internal-link-selector" onKeyDown={onPressEnter} > diff --git a/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonEdit.ts b/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonEdit.ts index 0e1bb05b1..5fb2618cf 100644 --- a/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonEdit.ts +++ b/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonEdit.ts @@ -106,10 +106,7 @@ export const useFloatingButtonEdit = ( useFloatingButtonEscape(); return { - style: { - ...style, - zIndex: 1000, - }, + style, ref: useComposedRef(floating), }; }; diff --git a/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonInsert.ts b/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonInsert.ts index 0fff8ce1b..30d907592 100644 --- a/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonInsert.ts +++ b/packages/guideline-blocks-settings/src/components/RichTextEditor/plugins/ButtonPlugin/components/FloatingButton/useFloatingButtonInsert.ts @@ -64,10 +64,7 @@ export const useFloatingButtonInsert = ( useFloatingButtonEscape(); return { - style: { - ...style, - zIndex: 1000, - }, + style, ref: useComposedRef(floating), }; };