Add check double spend and fix broken deser in old exec WASM

Author: AurelienFT

Cargo.lock

@@ -348,6 +348,13 @@ pub struct ExecutionOptions {
     pub backtrace: bool,
 }
 
+#[derive(serde::Deserialize, Debug)]
+/// Execution options to maintain for backward compatibility.
+pub struct ExecutionOptionsDeserialized {
+    pub forbid_fake_coins: bool,
+    pub backtrace: bool,
+}
+
 /// Per-block execution options
 #[derive(Clone, Default, Debug)]
 struct ExecutionOptionsInner {

crates/services/executor/src/executor.rs

@@ -22,7 +22,10 @@ use fuel_core_types::{
         },
     },
 };
-use fxhash::FxHashMap;
+use fxhash::{
+    FxHashMap,
+    FxHashSet,
+};
 
 use super::SchedulerError;
 
@@ -175,12 +178,14 @@ impl From<CoinInBatch> for CompressedCoin {
 
 pub struct CoinDependencyChainVerifier {
     coins_registered: FxHashMap<UtxoId, (usize, CoinInBatch)>,
+    coins_used: FxHashSet<UtxoId>,
 }
 
 impl CoinDependencyChainVerifier {
     pub fn new() -> Self {
         Self {
             coins_registered: FxHashMap::default(),
+            coins_used: FxHashSet::default(),
         }
     }
 
@@ -195,15 +200,23 @@ impl CoinDependencyChainVerifier {
     }
 
     pub fn verify_coins_used<'a, S>(
-        &self,
+        &mut self,
         batch_id: usize,
         coins_used: impl Iterator<Item = &'a CoinInBatch>,
         storage: &StorageTransaction<S>,
     ) -> Result<(), SchedulerError>
     where
         S: KeyValueInspect<Column = Column> + Send,
     {
+        // Check if the coins used are not already used and if they are valid
         for coin in coins_used {
+            if self.coins_used.contains(coin.utxo()) {
+                return Err(SchedulerError::InternalError(format!(
+                    "Coin {} is already used in the batch",
+                    coin.utxo(),
+                )));
+            }
+            self.coins_used.insert(*coin.utxo());
             match storage.storage::<Coins>().get(coin.utxo()) {
                 Ok(Some(db_coin)) => {
                     // Coin is in the database

crates/services/parallel-executor/src/scheduler/coin.rs

@@ -19,7 +19,10 @@ use crate::utils::{
     WasmDeserializationBlockTypes,
     convert_to_v1_execution_result,
 };
-use fuel_core_executor::executor::ExecutionInstance;
+use fuel_core_executor::executor::{
+    ExecutionInstance,
+    ExecutionOptions,
+};
 use fuel_core_types::{
     blockchain::block::Block,
     services::{
@@ -91,7 +94,11 @@ pub fn execute_without_commit(input_len: u32) -> ReturnType {
     let instance = ExecutionInstance {
         relayer: WasmRelayer {},
         database: WasmStorage {},
-        options,
+        options: ExecutionOptions {
+            forbid_unauthorized_inputs: options.forbid_fake_coins,
+            forbid_fake_utxo: options.forbid_fake_coins,
+            backtrace: options.backtrace,
+        },
     };
 
     match block {

crates/services/upgradable-executor/wasm-executor/src/main.rs

@@ -1,4 +1,7 @@
-use fuel_core_executor::executor::ExecutionOptions;
+use fuel_core_executor::executor::{
+    ExecutionOptions,
+    ExecutionOptionsDeserialized,
+};
 use fuel_core_storage::transactional::Changes;
 use fuel_core_types::{
     blockchain::block::Block,
@@ -60,7 +63,7 @@ pub enum InputSerializationType<'a> {
 pub enum InputDeserializationType {
     V1 {
         block: WasmDeserializationBlockTypes<()>,
-        options: ExecutionOptions,
+        options: ExecutionOptionsDeserialized,
     },
 }