PR adjustments

Author: xunilrj

sway-core/src/ir_generation/function.rs

@@ -457,7 +457,7 @@ impl<'a> FnCompiler<'a> {
         ))
     }
 
-    // Can be used to raw untyped slice and string slice
+    // Can be used for raw untyped slice and string slice
     fn compile_slice(
         &mut self,
         context: &mut Context,

sway-core/src/language/literal.rs

@@ -95,6 +95,7 @@ impl PartialEq for Literal {
             (Self::Numeric(l0), Self::Numeric(r0)) => l0 == r0,
             (Self::Boolean(l0), Self::Boolean(r0)) => l0 == r0,
             (Self::B256(l0), Self::B256(r0)) => l0 == r0,
+            (Self::Binary(l0), Self::Binary(r0)) => l0 == r0,
             _ => false,
         }
     }

sway-core/src/semantic_analysis/ast_node/expression/typed_expression/method_application.rs

@@ -534,10 +534,10 @@ pub(crate) fn type_check_method_application(
         }
 
         fn method_name_literal(method_name: &BaseIdent) -> Expression {
-            let method_name_str = method_name.as_str().to_string();
+            let method_name_str = method_name.as_str();
             let len_bytes = (method_name_str.len() as u64).to_be_bytes();
 
-            let mut blob = vec![];
+            let mut blob = Vec::with_capacity(len_bytes.len() + method_name_str.len());
             blob.extend(len_bytes);
             blob.extend(method_name_str.as_bytes());
 

sway-lsp/src/traverse/parsed_tree.rs

@@ -1252,6 +1252,6 @@ fn literal_to_symbol_kind(value: &Literal) -> SymbolKind {
         Literal::String(..) => SymbolKind::StringLiteral,
         Literal::B256(..) => SymbolKind::ByteLiteral,
         Literal::Boolean(..) => SymbolKind::BoolLiteral,
-        Literal::Binary(_) => todo!(),
+        Literal::Binary(_) => unreachable!("literals cannot be expressed in the language yet"),
     }
 }

sway-lsp/src/utils/debug.rs

@@ -67,7 +67,7 @@ fn literal_to_string(literal: &Literal) -> String {
         Literal::String(len) => format!("str[{}]", len.as_str().len()),
         Literal::Boolean(_) => "bool".into(),
         Literal::B256(_) => "b256".into(),
-        Literal::Binary(_) => todo!(),
+        Literal::Binary(_) => unreachable!("literals cannot be expressed in the language yet"),
     }
 }