fix rebase issues

xunilrj · xunilrj · commit 785a08074140 · 2025-10-20T15:59:08.000-03:00
diff --git a/scripts/csv2html/csv2html.sh b/scripts/csv2html/csv2html.sh
@@ -57,8 +57,4 @@ tail -n +2 "$1" | sed -e 's/^/<tr><td>/' -e 's/,/<\/td><td>/g' -e 's/$/<\/td><\/
 echo "      </tbody>
         </table>
     <body>
-<<<<<<< HEAD
 </html>"
-=======
-</html>"
->>>>>>> bdd5b43f5 (fixing CI)
diff --git a/sway-core/src/ir_generation/convert.rs b/sway-core/src/ir_generation/convert.rs
@@ -14,6 +14,15 @@ use sway_types::{integer_bits::IntegerBits, span::Span};
 
 pub(super) fn convert_literal_to_value(context: &mut Context, ast_literal: &Literal) -> Value {
     match ast_literal {
+        // In Sway for now we don't have `as` casting and for integers which may be implicitly cast
+        // between widths we just emit a warning, and essentially ignore it. We also assume a
+        // 'Numeric' integer of undetermined width is 'u64`. The IR would like to be type
+        // consistent and doesn't tolerate missing integers of different width, so for now, until we
+        // do introduce explicit `as` casting, all integers are `u64` as far as the IR is
+        // concerned.
+        //
+        // XXX The above isn't true for other targets.  We need to improved this.
+        // FIXME
         Literal::U8(n) => ConstantContent::get_uint(context, 8, *n as u64),
         Literal::U16(n) => ConstantContent::get_uint(context, 64, *n as u64),
         Literal::U32(n) => ConstantContent::get_uint(context, 64, *n as u64),
@@ -32,6 +41,7 @@ pub(super) fn convert_literal_to_constant(
     ast_literal: &Literal,
 ) -> Constant {
     let c = match ast_literal {
+        // All integers are `u64`.  See comment above.
         Literal::U8(n) => ConstantContent::new_uint(context, 8, *n as u64),
         Literal::U16(n) => ConstantContent::new_uint(context, 64, *n as u64),
         Literal::U32(n) => ConstantContent::new_uint(context, 64, *n as u64),
