Skip to content

Commit 1809dd8

Browse files
essential-randomnessessential-randomness
committed
fix tests and add more data validation checks
1 parent 8aecc67 commit 1809dd8

File tree

62 files changed

+2311
-2143
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+2311
-2143
lines changed

‎.github/workflows/data-refresh-validation.yaml‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
name: Validate data refresh PR
2+
3+
on:
4+
pull_request:
5+
branches: [main]
6+
types: [opened, synchronize, reopened]
7+
8+
jobs:
9+
validate-data-refresh:
10+
runs-on: ubuntu-latest
11+
if: startsWith(github.head_ref, 'data-refresh-')
12+
13+
steps:
14+
- name: Checkout repository
15+
uses: actions/checkout@v4
16+
17+
- name: Setup Node.js
18+
uses: actions/setup-node@v4
19+
with:
20+
node-version: "22"
21+
cache: "npm"
22+
23+
- name: Install dependencies
24+
run: npm ci
25+
26+
- name: Run tests
27+
run: npm test
28+
29+
data-refresh-check:
30+
runs-on: ubuntu-latest
31+
needs: [validate-data-refresh]
32+
if: always()
33+
34+
steps:
35+
- name: Determine result
36+
run: |
37+
if [[ "${{ needs.validate-data-refresh.result }}" == "failure" ]]; then
38+
echo "❌ Data refresh validation failed!"
39+
echo "Tests are failing - please fix before merging."
40+
exit 1
41+
elif [[ "${{ needs.validate-data-refresh.result }}" == "success" ]]; then
42+
echo "✅ Data refresh validation passed!"
43+
else
44+
echo "⏭️ Data refresh validation skipped (not a data-refresh PR)"
45+
fi

‎.github/workflows/data-refresh.yaml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,13 @@ jobs:
137137
Changes look _yikes_? ❌ Check out this PR and go get 'em! 💪🔥`
138138
});
139139
140+
await github.rest.issues.addLabels({
141+
owner: context.repo.owner,
142+
repo: context.repo.repo,
143+
issue_number: pr.data.number,
144+
labels: ['data-refresh']
145+
});
146+
140147
create-failure-pr-and-issue:
141148
runs-on: ubuntu-latest
142149
needs: [test-data, update-snapshots]
@@ -189,3 +196,11 @@ jobs:
189196
190197
Want to learn more about this issue and help us fix it? Check out the [README](https://github.com/FujoWebDev/AO3.js/blob/main/README.md#about--data-refresh-tests-failed-issues) for more information!`
191198
});
199+
200+
// Add label to the PR for easy identification
201+
await github.rest.issues.addLabels({
202+
owner: context.repo.owner,
203+
repo: context.repo.repo,
204+
issue_number: pr.data.number,
205+
labels: ['data-refresh']
206+
});

‎tests/mocks/data/ao3/series/1728802/index.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<script src="/javascripts/livevalidation_standalone.js"></script>
3535

3636
<meta name="csrf-param" content="authenticity_token" />
37-
<meta name="csrf-token" content="KHissH7fHMNsFaK5vxFiOvUK7Xw03ZZMngpeM9ESQnYfRpTIo5R4LbqedZlfkB8KPt6p_v7lbT9EcSY0hnyY3A" />
37+
<meta name="csrf-token" content="pLUrsqTCOJEIelDLlDWOEFPa1G0PNiQrP6ece3e9Nq-d-slTpponZthA2UdSCGJM76cKFQD52lZlbhzpoelL3w" />
3838

3939

4040
</head>
@@ -57,7 +57,7 @@ <h1 class="heading">
5757
<a id="login-dropdown" href="/users/login?return_to=%2Fseries%2F1728802%3Fview_adult%3Dtrue">Log In</a>
5858
</p>
5959
<div id="small_login" class="simple login">
60-
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F1728802%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="suPLtdmmjKIPH0vPgeYd6Mw_2YKM06zaUXjdosEduFMG94R32W1-8WMEwfmbbjGRQpKfGv-vvo1tV-ZYBeffrA" autocomplete="off" />
60+
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F1728802%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="XTPr3l-ZWu0hH_SQe0W5OKA5GZ3OxTfV3jist7kmbVNht02lDXT0HuuwSFTfOrYDC_bjai7gjYbXk8sptfscyA" autocomplete="off" />
6161
<dl>
6262
<dt><label for="user_session_login_small">Username or email:</label></dt>
6363
<dd><input autocomplete="on" id="user_session_login_small" type="text" name="user[login]" /></dd>
@@ -138,7 +138,7 @@ <h1 class="heading">
138138
<p>
139139
<label class="landmark" for="site_search">Work Search</label>
140140
<input class="text" id="site_search" aria-describedby="site_search_tooltip" type="text" name="work_search[query]" />
141-
<span class="tip" role="tooltip" id="site_search_tooltip">tip: lex m/m (mature OR explicit)</span>
141+
<span class="tip" role="tooltip" id="site_search_tooltip">tip: &quot;uchiha sasuke/uzumaki naruto&quot; angst kudos&gt;10</span>
142142
<span class="submit actions"><input type="submit" value="Search" class="button" /></span>
143143
</p>
144144
</fieldset>

‎tests/mocks/data/ao3/series/2817877/index.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<script src="/javascripts/livevalidation_standalone.js"></script>
3535

3636
<meta name="csrf-param" content="authenticity_token" />
37-
<meta name="csrf-token" content="nsSKyx30JA4slT1Pbnp4T4l7jVHn_LrvEslcUhp6Psa8BXveoS3bfHCB6a3qWXA763hlODh9UNdw8iVjXuOPMA" />
37+
<meta name="csrf-token" content="LgTaOAacc77Zemjac3QSRwJU57_LRvgfr8wCTZk4fEKy1WoZQvFOxLug2yhlgBj8xfUDAX6VjWLTBWsBFmm8BA" />
3838

3939

4040
</head>
@@ -57,7 +57,7 @@ <h1 class="heading">
5757
<a id="login-dropdown" href="/users/login?return_to=%2Fseries%2F2817877%3Fview_adult%3Dtrue">Log In</a>
5858
</p>
5959
<div id="small_login" class="simple login">
60-
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F2817877%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="hMTtnZ_LksktRDp8791aehXuO2yj_Gn457wa5psHEyO6Apuc1j-j31ZY7g9_kkvvvgtCi5TZaEK6SLSj20TFig" autocomplete="off" />
60+
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F2817877%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="FdAgrRhxEyoOGelHty_6MHDgZYsC5UHluLuPFpLVnijeJPxrZ6DZUUl_Vxrhm8kiaUg7dnaSd5WyTeqgIoOtSA" autocomplete="off" />
6161
<dl>
6262
<dt><label for="user_session_login_small">Username or email:</label></dt>
6363
<dd><input autocomplete="on" id="user_session_login_small" type="text" name="user[login]" /></dd>
@@ -138,7 +138,7 @@ <h1 class="heading">
138138
<p>
139139
<label class="landmark" for="site_search">Work Search</label>
140140
<input class="text" id="site_search" aria-describedby="site_search_tooltip" type="text" name="work_search[query]" />
141-
<span class="tip" role="tooltip" id="site_search_tooltip">tip: &quot;sherlock (tv)&quot; m/m NOT &quot;sherlock holmes/john watson&quot;</span>
141+
<span class="tip" role="tooltip" id="site_search_tooltip">tip: buffy gen teen AND &quot;no archive warnings apply&quot;</span>
142142
<span class="submit actions"><input type="submit" value="Search" class="button" /></span>
143143
</p>
144144
</fieldset>
@@ -885,7 +885,7 @@ <h6 class="landmark heading">Series</h6>
885885
<dd class="bookmarks"><a href="/works/76772566/bookmarks">68</a></dd>
886886

887887
<dt class="hits">Hits:</dt>
888-
<dd class="hits">3,515</dd>
888+
<dd class="hits">3,512</dd>
889889

890890
</dl>
891891

‎tests/mocks/data/ao3/series/2946579/index.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<script src="/javascripts/livevalidation_standalone.js"></script>
3535

3636
<meta name="csrf-param" content="authenticity_token" />
37-
<meta name="csrf-token" content="yMFAWGnJ0WfFtVnPEBH_V8vP9rmKfq4DzcK8a_KJ0msG284uMMBDsgghA03ZHjfWUCrBggfc72U6FbJzbv4EgQ" />
37+
<meta name="csrf-token" content="2yvs5Pu1VW1eZIVoy9uki5JdKBzLvDY-DwkkwG8qnWIIcbiJ1UB1Mn3cmLeCEktxH4TGWOqBkYkNDWNMSbstSg" />
3838

3939

4040
</head>
@@ -57,7 +57,7 @@ <h1 class="heading">
5757
<a id="login-dropdown" href="/users/login?return_to=%2Fseries%2F2946579%3Fview_adult%3Dtrue">Log In</a>
5858
</p>
5959
<div id="small_login" class="simple login">
60-
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F2946579%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="ia_T2WvL7K48AAkD4kdGNapnspZ5cikyGy2ECnocnqFrx8XQOfHZXKL3Nul4QBqs4XRcDqA7qscoKvFfRzzMMA" autocomplete="off" />
60+
<form class="new_user" id="new_user_session_small" action="/users/login?return_to=%2Fseries%2F2946579%3Fview_adult%3Dtrue" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="PmTwadlHIfMcs7ymQzUrLC8MHfP-WVhW3g7qAoEoye6BZqx5BzKiNHgLSNEYIxiGYklfoXhdK9WQoFC0oR3MmQ" autocomplete="off" />
6161
<dl>
6262
<dt><label for="user_session_login_small">Username or email:</label></dt>
6363
<dd><input autocomplete="on" id="user_session_login_small" type="text" name="user[login]" /></dd>
@@ -138,7 +138,7 @@ <h1 class="heading">
138138
<p>
139139
<label class="landmark" for="site_search">Work Search</label>
140140
<input class="text" id="site_search" aria-describedby="site_search_tooltip" type="text" name="work_search[query]" />
141-
<span class="tip" role="tooltip" id="site_search_tooltip">tip: hetalia f/f sort:kudos</span>
141+
<span class="tip" role="tooltip" id="site_search_tooltip">tip: arthur merlin words&gt;1000 sort:hits</span>
142142
<span class="submit actions"><input type="submit" value="Search" class="button" /></span>
143143
</p>
144144
</fieldset>

0 commit comments

Comments
 (0)