fix current tests

Author: essential-randomness

package.json

@@ -34,6 +34,7 @@
   "scripts": {
     "build": "vite build",
     "test": "vitest",
+    "test:update": "vitest -u",
     "dev": "vite build --watch",
     "coverage": "vitest run --coverage",
     "encode-mock-files": "ts-node-esm tests/mocks/scripts/encode-mock-files.mts",

src/page-loaders.ts

@@ -1,8 +1,10 @@
 import {
+  getSeriesUrl,
   getTagUrl,
   getTagWorksFeedAtomUrl,
   getTagWorksFeedUrl,
   getUserProfileUrl,
+  getWorkIndexUrl,
   getWorkUrl,
 } from "./urls";
 
@@ -105,17 +107,21 @@ export const loadUserProfilePage = async ({
 export interface ChapterIndexPage extends CheerioAPI {
   kind: "ChapterIndexPage";
 }
-export const loadChaptersIndexPage = async ({ workId }: { workId: ArchiveId }) => {
+export const loadChaptersIndexPage = async ({
+  workId,
+}: {
+  workId: ArchiveId;
+}) => {
   return await fetchPage<ChapterIndexPage>({
-    url: `https://archiveofourown.org/works/${workId}/navigate`,
+    url: getWorkIndexUrl({ workId }),
   });
 };
 
 export interface SeriesPage extends CheerioAPI {
   kind: "SeriesPage";
 }
-export const loadSeriesPage = async (seriesId: string) => {
+export const loadSeriesPage = async (seriesId: ArchiveId) => {
   return await fetchPage<SeriesPage>({
-    url: `https://archiveofourown.org/series/${seriesId}`,
+    url: getSeriesUrl({ seriesId }),
   });
 };

tests/tags.test.ts

@@ -1,5 +1,5 @@
 import { getTag } from "src/index";
-import { describe, it, expect } from 'vitest';
+import { describe, it, expect } from "vitest";
 
 describe("Tags/data", () => {
   it("should fetch id data for canonical tags", async () => {
@@ -233,8 +233,8 @@ describe("Tags/parent", () => {
     const tag = await getTag({ tagName: "Sherlock Holmes" });
 
     expect(tag.name).toBe("Sherlock Holmes");
-    expect(tag.parentTags).toEqual(
-      expect.arrayContaining([
+    expect(tag.parentTags).toMatchInlineSnapshot(`
+      [
         "221B Baker Towers",
         "A Study in Emerald - Neil Gaiman",
         "A Study in Terror (1965)",
@@ -251,8 +251,8 @@ describe("Tags/parent", () => {
         "Sherlock & Daughter (TV)",
         "Sherlock (TV)",
         "Sherlock Holmes & Related Fandoms",
-        "Sherlock Holmes (1984 TV)",
-        "Sherlock Holmes (Downey films)",
+        "Sherlock Holmes (Downey Movies)",
+        "Sherlock Holmes (Granada TV 1984)",
         "Sherlock Holmes (Radio 1989-2010 Coules)",
         "Sherlock Holmes (TV 1965)",
         "Sherlock Holmes - Arthur Conan Doyle",
@@ -266,13 +266,12 @@ describe("Tags/parent", () => {
         "Watson (TV 2025)",
         "Шерлок Холмс | Sherlock Holmes (TV 2013)",
         "名探偵ホームズ | Sherlock Hound",
-      ])
-    );
+      ]
+    `);
   });
 });
 
 describe("Tags/sub", () => {
-
   it("should fetch subtags", async () => {
     const tag = await getTag({ tagName: "Mind Palace" });
 

tests/user.test.ts

@@ -17,25 +17,28 @@ describe("User/data", () => {
       joined: "2008-09-13",
     } satisfies Partial<User>);
   });
-  // Fetches information about a user who filled in optional profile fields
-  it("should fetch user data from optional profile fields", async () => {
+
+  it("should fetch HTML bio from profile fields", async () => {
     const astolat = await getUser({
       username: "astolat",
     });
 
     expect(astolat.bioHtml).toMatchInlineSnapshot(
       `"<p>I <a href="https://astolat.dreamwidth.org/125056.html" rel="nofollow">built this city</a>.</p><p>I&apos;m also: <a href="https://astolat.tumblr.com" rel="nofollow">astolat @ Tumblr</a>, <a href="https://twitter.com/intimations" rel="nofollow">@intimations on Twitter</a>, <a href="https://www.youtube.com/user/astolatvids" rel="nofollow">astolatvids on YouTube</a>.</p><p><strong>Blanket Permission Policy</strong><br>I love transformative works based on my work. As long as it&apos;s noncommercial and credit is given, you don&apos;t need to ask permission. More than one person is welcome to podfic/translate/sequel/illustrate/etc any given story. Please post your work here and cite my original story as a related work, so I can link back!</p><p>You can look at my <a href="https://archiveofourown.org/users/astolat/related_works" rel="nofollow">Related Works</a> listing to see existing translations, podfics, and other related works.</p><p><strong>Warnings</strong><br>My work is labeled Choose Not To Warn unless I am confident it is safe. Most of my work is not! I do add more specific warnings sometimes, but my judgement may not align with yours. I don&apos;t tag exhaustively for every story element that appears in my work.</p><p><strong>Collections</strong><br>If you want to add one of my stories to a collection, please bookmark it and add your bookmark to the collection instead. I don&apos;t approve collection requests anymore because of abuse, sorry. :/</p><p><strong>Personal</strong><br>I&#x2019;m a pro writer IRL and my identity is a fairly open secret in fandom, but I prefer not crossing the streams. It&#x2019;s fine to ask about and share it privately, but please don&#x2019;t out me in public and googleable places. That includes comments and tumblr posts/comments! Thank you!</p><p><strong>Pronouns:</strong> she/her</p>"`
     );
+  });
 
+  it("should fetch user data from optional profile fields", async () => {
     const franzeska = await getUser({
       username: "franzeska",
     });
 
     expect(franzeska).toMatchObject({
       username: "Franzeska",
       id: "87",
-      location: "Oakland",
-      birthday: "1981-02-13",
+      // Note: birthday and location were recently removed from AO3, but might still
+      // be visible in other archives
+      // TODO: use another archive to test this
       icon: expect.stringMatching(
         /^https:\/\/archiveofourown\.org\/rails\/active_storage\/representations\/proxy\/[^/]+\/[^/]+\/original\.jpg$/
       ),