Skip to content

Commit ac16074

Browse files
lmamminoandreamangano
authored andcommitted
Fixed and improved social share urls and open graph images (#23)
1 parent 134d9e8 commit ac16074

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

views/_layout.pug

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ html(lang=meta.lang prefix="og: http://ogp.me/ns#")
1919
meta(property="og:site_name" content=meta.title)
2020
meta(property="og:type" content="website")
2121
meta(property="og:url" content=meta.canonicalUrl)
22-
meta(property="og:image" content="/images/share-banner-facebook.jpg")
22+
meta(property="og:image" content=`${meta.canonicalUrl}/images/share-banner-facebook.jpg`)
2323
meta(property="og:locale" content=meta.locale)
2424
meta(property="twitter:card" content="website")
2525
meta(property="twitter:site" content=meta.twitterProfile)
2626
meta(property="twitter:title" content=meta.title)
2727
meta(property="twitter:description" content=meta.description)
28-
meta(property="twitter:image" content="/images/share-banner-twitter.jpg")
28+
meta(property="twitter:image" content=`${meta.canonicalUrl}/images/share-banner-twitter.jpg`)
2929

3030
link(rel="canonical" href=meta.canonicalUrl)
3131
link(rel="apple-touch-icon" sizes="57x57" href="/apple-icon-57x57.png")

views/components/_social-share.pug

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
mixin social-share(link, title)
22
- var url = `https://fullstackbulletin.com/${link}`;
3-
- var twitterSharePageUrl = `https://twitter.com/intent/tweet/?text=${title}&url=${url}`
3+
- var twitterSharePageUrl = `https://twitter.com/intent/tweet/?text=${title}&url=${url}&via=fstackbulletin`
44
- var facebookSharePageUrl = `https://facebook.com/sharer/sharer.php?u=${url}`;
5-
- var linkedinSharePageUrl = `https://www.linkedin.com/shareArticle?mini=true&url=${url}&title=${title}&summary=${title}&source=Focus+Risparmio`;
5+
- var linkedinSharePageUrl = `https://www.linkedin.com/shareArticle?mini=true&url=${url}&title=${title}&summary=${title}&source=Fullstack+Bulletin`;
66

77
.social-share
88
.social-share__list
99
.social-share__item
10-
a.social-share__link(href=facebookSharePageUrl)
10+
a.social-share__link(href=facebookSharePageUrl target="_blank")
1111
.social-share__icon
1212
+icon({name: "facebook"})
1313
.social-share__text Facebook
1414
.social-share__item
15-
a.social-share__link(href=twitterSharePageUrl)
15+
a.social-share__link(href=twitterSharePageUrl target="_blank")
1616
.social-share__icon
1717
+icon({name: "twitter"})
1818
.social-share__text Twitter
1919
.social-share__item
20-
a.social-share__link.social-share__link--linkedin(href=linkedinSharePageUrl)
20+
a.social-share__link.social-share__link--linkedin(href=linkedinSharePageUrl target="_blank")
2121
.social-share__icon
2222
+icon({name: "linkedin"})
2323
.social-share__text Linkedin

0 commit comments

Comments
 (0)